Change in coreboot[master]: util/autoport: Adapt logmaker for newer ACPI versions - coreboot-gerrit

11 Aug 2018


      Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/28054 )
Change subject: util/autoport: Adapt logmaker for newer ACPI versions
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/28054/2/util/autoport/log_reader.go
File util/autoport/log_reader.go:
https://review.coreboot.org/#/c/28054/2/util/autoport/log_reader.go@109
PS2, Line 109: 		var tmp_int uint
             : 		_, is_err := fmt.Sscanf(line, "%X: ", &tmp_int)
             : 		is_hexline := is_err == nil
there is probably a better way to do this...
-- 
To view, visit https://review.coreboot.org/28054
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d48c09cdff9432f394b350540ea9765fc942781
Gerrit-Change-Number: 28054
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Sat, 11 Aug 2018 23:39:54 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No