Attention is currently required from: Tarun Tuli, Kyle Lin, Derek Huang, Kapil Porwal, Reka Norman, Ivy Jian, Eric Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71988 )
Change subject: soc/intel/adl: Option to create unified AP FW for UFS/Non-UFS SKUs
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Please make sure extra warm boot can pass the FAFT...
may be I'm missing something but u can guide me, what specific scenarios/test you think FAFT will fail due to extra warm reset?
Do FAFT is aware of boot mode? I'm trying to think how it can even expect that. As per FSP policy there could be many reasons when FSP override straps and issue warm reset to take it into effect like CPuflexratio. Are we expecting extra warm reset in boot path might result into FAFT failure? if yes, which test scenario?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71988
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0a811d8f4aad41dab6f8988329eaa1d590a4637a
Gerrit-Change-Number: 71988
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Kyle Lin
kylelinck@google.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kyle Lin
kylelinck@google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 16 Jan 2023 16:05:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment