Philip Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31814
Change subject: mb/google/hatch: Define GPP_C13 as EC_SYNC_IRQ ......................................................................
mb/google/hatch: Define GPP_C13 as EC_SYNC_IRQ
BUG=b:125933998 BRANCH=None TEST=None
Signed-off-by: Philip Chen philipchen@google.com Change-Id: I1dd38ca5aed1e0ddecb4738910cbfa92de33d315 --- M src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h M src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h 2 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/31814/1
diff --git a/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h index 75d583e..df05e88 100644 --- a/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h +++ b/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h @@ -78,6 +78,9 @@ #define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */ #define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */
+/* Enable EC sync interrupt, EC_SYNC_IRQ is defined in baseboard/gpio.h */ +#define EC_ENABLE_SYNC_IRQ + /* Enable EC backed Keyboard Backlight in ACPI */ #define EC_ENABLE_KEYBOARD_BACKLIGHT
diff --git a/src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h b/src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h index 0cdec46..5d6311b 100644 --- a/src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h +++ b/src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h @@ -35,4 +35,7 @@ /* eSPI virtual wire reporting */ #define EC_SCI_GPI GPE0_ESPI
+/* EC sync irq is GPP_C13_IRQ */ +#define EC_SYNC_IRQ GPP_C13_IRQ + #endif /* BASEBOARD_GPIO_H */
Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31814 )
Change subject: mb/google/hatch: Define GPP_C13 as EC_SYNC_IRQ ......................................................................
Patch Set 3:
This change is ready for review.
Enrico Granata has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31814 )
Change subject: mb/google/hatch: Define GPP_C13 as EC_SYNC_IRQ ......................................................................
Patch Set 3: Code-Review+1
Someone with insight on the board layout should make sure it's the right pin
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31814 )
Change subject: mb/google/hatch: Define GPP_C13 as EC_SYNC_IRQ ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31814 )
Change subject: mb/google/hatch: Define GPP_C13 as EC_SYNC_IRQ ......................................................................
mb/google/hatch: Define GPP_C13 as EC_SYNC_IRQ
BUG=b:125933998 CQ-DEPEND=CL:1510513 BRANCH=None TEST=manually verify on hatch, chromeos-ec interrupt count increases
Signed-off-by: Philip Chen philipchen@google.com Change-Id: I1dd38ca5aed1e0ddecb4738910cbfa92de33d315 Reviewed-on: https://review.coreboot.org/c/coreboot/+/31814 Reviewed-by: Enrico Granata egranata@google.com Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h M src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h 2 files changed, 6 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Enrico Granata: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h index 75d583e..df05e88 100644 --- a/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h +++ b/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h @@ -78,6 +78,9 @@ #define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */ #define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */
+/* Enable EC sync interrupt, EC_SYNC_IRQ is defined in baseboard/gpio.h */ +#define EC_ENABLE_SYNC_IRQ + /* Enable EC backed Keyboard Backlight in ACPI */ #define EC_ENABLE_KEYBOARD_BACKLIGHT
diff --git a/src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h b/src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h index 0cdec46..5d6311b 100644 --- a/src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h +++ b/src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h @@ -35,4 +35,7 @@ /* eSPI virtual wire reporting */ #define EC_SCI_GPI GPE0_ESPI
+/* EC sync irq is GPP_C13_IRQ */ +#define EC_SYNC_IRQ GPP_C13_IRQ + #endif /* BASEBOARD_GPIO_H */
-
Enrico Granata (Code Review) -
Furquan Shaikh (Code Review)
-
Patrick Georgi (Code Review)
-
Philip Chen (Code Review)