Patrick Georgi merged this change.

View Change

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Enrico Granata: Looks good to me, but someone else must approve
mb/google/hatch: Define GPP_C13 as EC_SYNC_IRQ

BUG=b:125933998
CQ-DEPEND=CL:1510513
BRANCH=None
TEST=manually verify on hatch, chromeos-ec interrupt count increases

Signed-off-by: Philip Chen <philipchen@google.com>
Change-Id: I1dd38ca5aed1e0ddecb4738910cbfa92de33d315
Reviewed-on: https://review.coreboot.org/c/coreboot/+/31814
Reviewed-by: Enrico Granata <egranata@google.com>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h
M src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h
2 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h
index 75d583e..df05e88 100644
--- a/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h
+++ b/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h
@@ -78,6 +78,9 @@
#define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */
#define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */

+/* Enable EC sync interrupt, EC_SYNC_IRQ is defined in baseboard/gpio.h */
+#define EC_ENABLE_SYNC_IRQ
+
/* Enable EC backed Keyboard Backlight in ACPI */
#define EC_ENABLE_KEYBOARD_BACKLIGHT

diff --git a/src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h b/src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h
index 0cdec46..5d6311b 100644
--- a/src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h
+++ b/src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h
@@ -35,4 +35,7 @@
/* eSPI virtual wire reporting */
#define EC_SCI_GPI GPE0_ESPI

+/* EC sync irq is GPP_C13_IRQ */
+#define EC_SYNC_IRQ GPP_C13_IRQ
+
#endif /* BASEBOARD_GPIO_H */

To view, visit change 31814. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1dd38ca5aed1e0ddecb4738910cbfa92de33d315
Gerrit-Change-Number: 31814
Gerrit-PatchSet: 4
Gerrit-Owner: Philip Chen <philipchen@google.com>
Gerrit-Reviewer: Enrico Granata <egranata@google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Philip Chen <philipchen@google.com>
Gerrit-Reviewer: Shelley Chen <shchen@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged