Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier.
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79836?usp=email )
Change subject: soc/amd: use apm_get_apmc() in APMC SMI handler ......................................................................
soc/amd: use apm_get_apmc() in APMC SMI handler
Instead of open-coding this functionality, call the apm_get_apmc() helper function.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Iac6b614d900e51d91a0c155116a5edc29775ea99 --- M src/soc/amd/common/block/cpu/smm/smi_apmc.c M src/soc/amd/stoneyridge/smihandler.c 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/79836/1
diff --git a/src/soc/amd/common/block/cpu/smm/smi_apmc.c b/src/soc/amd/common/block/cpu/smm/smi_apmc.c index 0eab86c..9df6ae3 100644 --- a/src/soc/amd/common/block/cpu/smm/smi_apmc.c +++ b/src/soc/amd/common/block/cpu/smm/smi_apmc.c @@ -91,7 +91,7 @@
void fch_apmc_smi_handler(void) { - const uint8_t cmd = inb(pm_acpi_smi_cmd_port()); + const uint8_t cmd = apm_get_apmc();
switch (cmd) { case APM_CNT_ACPI_ENABLE: diff --git a/src/soc/amd/stoneyridge/smihandler.c b/src/soc/amd/stoneyridge/smihandler.c index a8521c5..f962fa0 100644 --- a/src/soc/amd/stoneyridge/smihandler.c +++ b/src/soc/amd/stoneyridge/smihandler.c @@ -21,7 +21,7 @@ */ static void stoneyridge_fch_apmc_smi_handler(void) { - const uint8_t cmd = inb(pm_acpi_smi_cmd_port()); + const uint8_t cmd = apm_get_apmc();
switch (cmd) { case APM_CNT_ACPI_ENABLE: