Hello Piotr Kleinschmidt,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/38275
to review the following change.
Change subject: mb/pcengines/*: enable simple IO-based GPIO control ......................................................................
mb/pcengines/*: enable simple IO-based GPIO control
Add GPIO IO VLDN and define an IO base address unused by any peripheral for GPIO use.
Signed-off-by: Piotr Kleinschmidt piotr.kleinschmidt@3mdeb.com Signed-off-by: Michał Żygowski michal.zygowski@3mdeb.com Change-Id: I034c5d0169b8d97eac97a20c92c22816fd674f79 --- M src/mainboard/pcengines/apu1/devicetree.cb M src/mainboard/pcengines/apu2/variants/apu2/devicetree.cb M src/mainboard/pcengines/apu2/variants/apu3/devicetree.cb M src/mainboard/pcengines/apu2/variants/apu4/devicetree.cb M src/mainboard/pcengines/apu2/variants/apu5/devicetree.cb 5 files changed, 18 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/38275/1
diff --git a/src/mainboard/pcengines/apu1/devicetree.cb b/src/mainboard/pcengines/apu1/devicetree.cb index d7c7952..767b0b0 100644 --- a/src/mainboard/pcengines/apu1/devicetree.cb +++ b/src/mainboard/pcengines/apu1/devicetree.cb @@ -62,7 +62,10 @@ io 0x60 = 0x2e8 irq 0x70 = 3 end - device pnp 2e.8 off end + device pnp 2e.008 off end + device pnp 2e.108 on + io 0x60 = 0x220 + end # GPIO0 and GPIO1 are conditionally turned on device pnp 2e.007 off end device pnp 2e.107 off end diff --git a/src/mainboard/pcengines/apu2/variants/apu2/devicetree.cb b/src/mainboard/pcengines/apu2/variants/apu2/devicetree.cb index b888ae7..443e150 100644 --- a/src/mainboard/pcengines/apu2/variants/apu2/devicetree.cb +++ b/src/mainboard/pcengines/apu2/variants/apu2/devicetree.cb @@ -64,7 +64,10 @@ io 0x60 = 0x2e8 irq 0x70 = 3 end - device pnp 2e.8 off end + device pnp 2e.008 off end + device pnp 2e.108 on + io 0x60 = 0x220 + end # GPIO0 and GPIO1 are conditionally turned on device pnp 2e.007 on end device pnp 2e.107 on end diff --git a/src/mainboard/pcengines/apu2/variants/apu3/devicetree.cb b/src/mainboard/pcengines/apu2/variants/apu3/devicetree.cb index ad29965..524f30f 100644 --- a/src/mainboard/pcengines/apu2/variants/apu3/devicetree.cb +++ b/src/mainboard/pcengines/apu2/variants/apu3/devicetree.cb @@ -64,7 +64,10 @@ io 0x60 = 0x2e8 irq 0x70 = 3 end - device pnp 2e.8 off end + device pnp 2e.008 off end + device pnp 2e.108 on + io 0x60 = 0x220 + end # GPIO0 and GPIO1 are conditionally turned on device pnp 2e.007 on end device pnp 2e.107 on end diff --git a/src/mainboard/pcengines/apu2/variants/apu4/devicetree.cb b/src/mainboard/pcengines/apu2/variants/apu4/devicetree.cb index c5b20c9..5aa0748 100644 --- a/src/mainboard/pcengines/apu2/variants/apu4/devicetree.cb +++ b/src/mainboard/pcengines/apu2/variants/apu4/devicetree.cb @@ -64,7 +64,10 @@ io 0x60 = 0x2e8 irq 0x70 = 3 end - device pnp 2e.8 off end + device pnp 2e.008 off end + device pnp 2e.108 on + io 0x60 = 0x220 + end # GPIO0 and GPIO1 are conditionally turned on device pnp 2e.007 on end device pnp 2e.107 on end diff --git a/src/mainboard/pcengines/apu2/variants/apu5/devicetree.cb b/src/mainboard/pcengines/apu2/variants/apu5/devicetree.cb index b6b22cf..c819114 100644 --- a/src/mainboard/pcengines/apu2/variants/apu5/devicetree.cb +++ b/src/mainboard/pcengines/apu2/variants/apu5/devicetree.cb @@ -64,7 +64,8 @@ io 0x60 = 0x2e8 irq 0x70 = 3 end - device pnp 2e.8 off end + device pnp 2e.008 off end + device pnp 2e.108 off end device pnp 2e.f off end device pnp 2e.007 off end device pnp 2e.107 off end
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38275 )
Change subject: mb/pcengines/*: enable simple IO-based GPIO control ......................................................................
Patch Set 1: Code-Review+1
looks good to me; the buildbot error is likely unrelated
Hello Felix Held, Piotr Król, Piotr Kleinschmidt, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38275
to look at the new patch set (#3).
Change subject: mb/pcengines/*: enable simple IO-based GPIO control ......................................................................
mb/pcengines/*: enable simple IO-based GPIO control
Add Nuvoton NCT5104D GPIO IO VLDN and define an IO base address unused by any peripheral for GPIO use.
Signed-off-by: Piotr Kleinschmidt piotr.kleinschmidt@3mdeb.com Signed-off-by: Michał Żygowski michal.zygowski@3mdeb.com Change-Id: I034c5d0169b8d97eac97a20c92c22816fd674f79 --- M src/mainboard/pcengines/apu1/devicetree.cb M src/mainboard/pcengines/apu2/variants/apu2/devicetree.cb M src/mainboard/pcengines/apu2/variants/apu3/devicetree.cb M src/mainboard/pcengines/apu2/variants/apu4/devicetree.cb M src/mainboard/pcengines/apu2/variants/apu5/devicetree.cb 5 files changed, 18 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/38275/3
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38275 )
Change subject: mb/pcengines/*: enable simple IO-based GPIO control ......................................................................
Patch Set 3: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38275 )
Change subject: mb/pcengines/*: enable simple IO-based GPIO control ......................................................................
mb/pcengines/*: enable simple IO-based GPIO control
Add Nuvoton NCT5104D GPIO IO VLDN and define an IO base address unused by any peripheral for GPIO use.
Signed-off-by: Piotr Kleinschmidt piotr.kleinschmidt@3mdeb.com Signed-off-by: Michał Żygowski michal.zygowski@3mdeb.com Change-Id: I034c5d0169b8d97eac97a20c92c22816fd674f79 Reviewed-on: https://review.coreboot.org/c/coreboot/+/38275 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/pcengines/apu1/devicetree.cb M src/mainboard/pcengines/apu2/variants/apu2/devicetree.cb M src/mainboard/pcengines/apu2/variants/apu3/devicetree.cb M src/mainboard/pcengines/apu2/variants/apu4/devicetree.cb M src/mainboard/pcengines/apu2/variants/apu5/devicetree.cb 5 files changed, 18 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/src/mainboard/pcengines/apu1/devicetree.cb b/src/mainboard/pcengines/apu1/devicetree.cb index d7c7952..767b0b0 100644 --- a/src/mainboard/pcengines/apu1/devicetree.cb +++ b/src/mainboard/pcengines/apu1/devicetree.cb @@ -62,7 +62,10 @@ io 0x60 = 0x2e8 irq 0x70 = 3 end - device pnp 2e.8 off end + device pnp 2e.008 off end + device pnp 2e.108 on + io 0x60 = 0x220 + end # GPIO0 and GPIO1 are conditionally turned on device pnp 2e.007 off end device pnp 2e.107 off end diff --git a/src/mainboard/pcengines/apu2/variants/apu2/devicetree.cb b/src/mainboard/pcengines/apu2/variants/apu2/devicetree.cb index b888ae7..443e150 100644 --- a/src/mainboard/pcengines/apu2/variants/apu2/devicetree.cb +++ b/src/mainboard/pcengines/apu2/variants/apu2/devicetree.cb @@ -64,7 +64,10 @@ io 0x60 = 0x2e8 irq 0x70 = 3 end - device pnp 2e.8 off end + device pnp 2e.008 off end + device pnp 2e.108 on + io 0x60 = 0x220 + end # GPIO0 and GPIO1 are conditionally turned on device pnp 2e.007 on end device pnp 2e.107 on end diff --git a/src/mainboard/pcengines/apu2/variants/apu3/devicetree.cb b/src/mainboard/pcengines/apu2/variants/apu3/devicetree.cb index ad29965..524f30f 100644 --- a/src/mainboard/pcengines/apu2/variants/apu3/devicetree.cb +++ b/src/mainboard/pcengines/apu2/variants/apu3/devicetree.cb @@ -64,7 +64,10 @@ io 0x60 = 0x2e8 irq 0x70 = 3 end - device pnp 2e.8 off end + device pnp 2e.008 off end + device pnp 2e.108 on + io 0x60 = 0x220 + end # GPIO0 and GPIO1 are conditionally turned on device pnp 2e.007 on end device pnp 2e.107 on end diff --git a/src/mainboard/pcengines/apu2/variants/apu4/devicetree.cb b/src/mainboard/pcengines/apu2/variants/apu4/devicetree.cb index c5b20c9..5aa0748 100644 --- a/src/mainboard/pcengines/apu2/variants/apu4/devicetree.cb +++ b/src/mainboard/pcengines/apu2/variants/apu4/devicetree.cb @@ -64,7 +64,10 @@ io 0x60 = 0x2e8 irq 0x70 = 3 end - device pnp 2e.8 off end + device pnp 2e.008 off end + device pnp 2e.108 on + io 0x60 = 0x220 + end # GPIO0 and GPIO1 are conditionally turned on device pnp 2e.007 on end device pnp 2e.107 on end diff --git a/src/mainboard/pcengines/apu2/variants/apu5/devicetree.cb b/src/mainboard/pcengines/apu2/variants/apu5/devicetree.cb index b6b22cf..c819114 100644 --- a/src/mainboard/pcengines/apu2/variants/apu5/devicetree.cb +++ b/src/mainboard/pcengines/apu2/variants/apu5/devicetree.cb @@ -64,7 +64,8 @@ io 0x60 = 0x2e8 irq 0x70 = 3 end - device pnp 2e.8 off end + device pnp 2e.008 off end + device pnp 2e.108 off end device pnp 2e.f off end device pnp 2e.007 off end device pnp 2e.107 off end
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38275 )
Change subject: mb/pcengines/*: enable simple IO-based GPIO control ......................................................................
Patch Set 4:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/187 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/186 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/185
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Felix Held (Code Review)
-
Michał Żygowski (Code Review)