Aaron Durbin (adurbin@chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13957
-gerrit
commit 9c565ab075a87bda2a5157cc64d1452552cba821 Author: Aaron Durbin adurbin@chromium.org Date: Tue Mar 8 10:59:46 2016 -0600
soc/intel/apollolake: correct comment to reference top of CAR
The memory provided to MemoryInit() for its own usage is at the top of the CAR region.
Change-Id: I8685b5ab138182e24123b14cac6f7b32e5e784d2 Signed-off-by: Aaron Durbin adurbin@chromium.org --- src/soc/intel/apollolake/romstage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/soc/intel/apollolake/romstage.c b/src/soc/intel/apollolake/romstage.c index 499417e..29a966e 100644 --- a/src/soc/intel/apollolake/romstage.c +++ b/src/soc/intel/apollolake/romstage.c @@ -142,7 +142,7 @@ void platform_fsp_memory_init_params_cb(struct FSPM_UPD *mupd) mupd->FspmConfig.FitTablePtr = read32((void*) FIT_POINTER); /* Reserve enough memory under TOLUD to save CBMEM header */ mupd->FspmArchUpd.BootLoaderTolumSize = cbmem_overhead_size(); - /* Let FSPM use memory right at the bottom of CAR */ + /* Let FSPM use memory right at the top of CAR */ /* TODO: Add checks to see if we collide with other areas */ mupd->FspmArchUpd.StackBase = _car_region_end - CONFIG_FSPM_STACK_SIZE; mupd->FspmArchUpd.StackSize = CONFIG_FSPM_STACK_SIZE;