Attention is currently required from: Subrata Banik, Kapil Porwal.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74005 )
Change subject: soc/intel/cmn: Implement HECI commands to get version details of ISHC
......................................................................
Patch Set 10:
(1 comment)
File src/soc/intel/common/block/include/intelblocks/cse.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-172909):
https://review.coreboot.org/c/coreboot/+/74005/comment/6dcdc710_3128c99d
PS10, Line 143: }fw_partition_version;
space required after that close brace '}'
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74005
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0582010bbb836bd4734f843a8c74dee49d203fd8
Gerrit-Change-Number: 74005
Gerrit-PatchSet: 10
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Mon, 03 Apr 2023 08:18:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment