Change in coreboot[master]: soc/mediatek/mt8192: enable CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE
Hello Ikjoon Jang,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/46382
to review the following change.
Change subject: soc/mediatek/mt8192: enable CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE ......................................................................
soc/mediatek/mt8192: enable CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE
BRANCH=none BUG=b:159079785 TEST=boot asurada
Change-Id: Ieb93073beff7ec95eb5406eecbfba8192f91edce Signed-off-by: Ikjoon Jang ikjn@chromium.org --- M src/soc/mediatek/mt8192/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/46382/1
diff --git a/src/soc/mediatek/mt8192/Kconfig b/src/soc/mediatek/mt8192/Kconfig index 1d1cf7b..18d9d41 100644 --- a/src/soc/mediatek/mt8192/Kconfig +++ b/src/soc/mediatek/mt8192/Kconfig @@ -5,6 +5,7 @@ select ARCH_VERSTAGE_ARMV8_64 select ARCH_ROMSTAGE_ARMV8_64 select ARCH_RAMSTAGE_ARMV8_64 + select ARM64_USE_ARM_TRUSTED_FIRMWARE select HAVE_UART_SPECIAL
if SOC_MEDIATEK_MT8192
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46382 )
Change subject: soc/mediatek/mt8192: enable CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE ......................................................................
Patch Set 3: Code-Review+2
Ikjoon Jang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46382 )
Change subject: soc/mediatek/mt8192: enable CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE ......................................................................
Patch Set 3: Code-Review+1
Hello Hung-Te Lin, build bot (Jenkins), Ikjoon Jang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46382
to look at the new patch set (#4).
Change subject: soc/mediatek/mt8192: enable CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE ......................................................................
soc/mediatek/mt8192: enable CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE
BRANCH=none BUG=b:159079785 TEST=boot asurada
Change-Id: Ieb93073beff7ec95eb5406eecbfba8192f91edce Signed-off-by: Ikjoon Jang ikjn@chromium.org --- M src/soc/mediatek/mt8192/Kconfig M src/soc/mediatek/mt8192/Makefile.inc 2 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/46382/4
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46382 )
Change subject: soc/mediatek/mt8192: enable CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE ......................................................................
Patch Set 4: Code-Review+2
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46382 )
Change subject: soc/mediatek/mt8192: enable CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE ......................................................................
Patch Set 4: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46382 )
Change subject: soc/mediatek/mt8192: enable CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46382/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46382/4//COMMIT_MSG@11 PS4, Line 11: TEST=boot asurada Before it didn’t work?
Please mention what ATF version you tested with.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46382 )
Change subject: soc/mediatek/mt8192: enable CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46382/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46382/4//COMMIT_MSG@11 PS4, Line 11: TEST=boot asurada
Before it didn’t work? […]
We use version 2.3 and the ATF patches are still under review. https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/4334
Hello Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth, Ikjoon Jang, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46382
to look at the new patch set (#5).
Change subject: soc/mediatek/mt8192: enable CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE ......................................................................
soc/mediatek/mt8192: enable CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE
BRANCH=none BUG=b:159079785 TEST=1. Checkout https://review.trustedfirmware.org/c/4334 2. emerge-asurada coreboot chromeos-bootimage 3. boot asurada
Change-Id: Ieb93073beff7ec95eb5406eecbfba8192f91edce Signed-off-by: Ikjoon Jang ikjn@chromium.org --- M src/soc/mediatek/mt8192/Kconfig M src/soc/mediatek/mt8192/Makefile.inc 2 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/46382/5
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46382 )
Change subject: soc/mediatek/mt8192: enable CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE ......................................................................
Patch Set 5: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/46382/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46382/4//COMMIT_MSG@11 PS4, Line 11: TEST=boot asurada
We use version 2.3 and the ATF patches are still under review. […]
Done
Hello Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth, Ikjoon Jang, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46382
to look at the new patch set (#6).
Change subject: soc/mediatek/mt8192: enable CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE ......................................................................
soc/mediatek/mt8192: enable CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE
BRANCH=none BUG=b:159079785 TEST=1. Checkout https://review.trustedfirmware.org/c/4334 2. emerge-asurada coreboot chromeos-bootimage 3. boot asurada
Change-Id: Ieb93073beff7ec95eb5406eecbfba8192f91edce Signed-off-by: Ikjoon Jang ikjn@chromium.org --- M src/soc/mediatek/mt8192/Kconfig M src/soc/mediatek/mt8192/Makefile.inc 2 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/46382/6
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46382 )
Change subject: soc/mediatek/mt8192: enable CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE ......................................................................
Patch Set 6:
re-order the patch series.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46382 )
Change subject: soc/mediatek/mt8192: enable CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE ......................................................................
Patch Set 6: Code-Review+2
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46382 )
Change subject: soc/mediatek/mt8192: enable CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE ......................................................................
Patch Set 6: Code-Review+2
Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46382 )
Change subject: soc/mediatek/mt8192: enable CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE ......................................................................
soc/mediatek/mt8192: enable CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE
BRANCH=none BUG=b:159079785 TEST=1. Checkout https://review.trustedfirmware.org/c/4334 2. emerge-asurada coreboot chromeos-bootimage 3. boot asurada
Change-Id: Ieb93073beff7ec95eb5406eecbfba8192f91edce Signed-off-by: Ikjoon Jang ikjn@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/46382 Reviewed-by: Hung-Te Lin hungte@chromium.org Reviewed-by: Yu-Ping Wu yupingso@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/mediatek/mt8192/Kconfig M src/soc/mediatek/mt8192/Makefile.inc 2 files changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Hung-Te Lin: Looks good to me, approved Yu-Ping Wu: Looks good to me, approved
diff --git a/src/soc/mediatek/mt8192/Kconfig b/src/soc/mediatek/mt8192/Kconfig index 1d1cf7b..18d9d41 100644 --- a/src/soc/mediatek/mt8192/Kconfig +++ b/src/soc/mediatek/mt8192/Kconfig @@ -5,6 +5,7 @@ select ARCH_VERSTAGE_ARMV8_64 select ARCH_ROMSTAGE_ARMV8_64 select ARCH_RAMSTAGE_ARMV8_64 + select ARM64_USE_ARM_TRUSTED_FIRMWARE select HAVE_UART_SPECIAL
if SOC_MEDIATEK_MT8192 diff --git a/src/soc/mediatek/mt8192/Makefile.inc b/src/soc/mediatek/mt8192/Makefile.inc index b047ce9..fb3b11d 100644 --- a/src/soc/mediatek/mt8192/Makefile.inc +++ b/src/soc/mediatek/mt8192/Makefile.inc @@ -36,6 +36,8 @@ ramstage-y += ../common/uart.c ramstage-y += ../common/usb.c usb.c
+BL31_MAKEARGS += PLAT=mt8192 + CPPFLAGS_common += -Isrc/soc/mediatek/mt8192/include CPPFLAGS_common += -Isrc/soc/mediatek/common/include
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46382 )
Change subject: soc/mediatek/mt8192: enable CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46382/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46382/4//COMMIT_MSG@11 PS4, Line 11: TEST=boot asurada
Done
It’d be great if you updated the commit messages next time, as other people likely have the same questions, and it’s not feasible to expect them to go through the Gerrit review comments.
-
Hung-Te Lin (Code Review) -
Ikjoon Jang (Code Review)
-
Paul Menzel (Code Review)
-
Yidi Lin (Code Review)
-
Yu-Ping Wu (Code Review)