You-Cheng Syu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31844
Change subject: google/kukui: Enable EC_GOOGLE_CHROMEEC_AP_WATCHDOG_FLAG ......................................................................
google/kukui: Enable EC_GOOGLE_CHROMEEC_AP_WATCHDOG_FLAG
Kukui AP doesn't remember if the last AP reset was due to AP watchdog. We need to enable EC_GOOGLE_CHROMEEC_AP_WATCHDOG_FLAG so that it will query the reset reason from EC during watchdog initialization.
Besides, we should set BOOTBLOCK_EN_L before mtk_wdt_init so that we can communicate with EC at the time.
BUG=b:109900671,b:118654976 BRANCH=none TEST=1. run 'mosys eventlog clear; stop daisydog; echo > /dev/watchdog' 2. wait for watchdog reset 3. see 'WDT: Last reset was hardware watchdog' in AP console 4. check 'mosys eventlog list | grep watchdog'
Change-Id: I053cc7664bbaf0d3fcae26ba9481a0ad700dca90 Signed-off-by: You-Cheng Syu youcheng@google.com --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/early_init.c 2 files changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/31844/1
diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index 9f477e5..4d4feac 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -33,6 +33,7 @@ select FATAL_ASSERTS select SPI_FLASH_INCLUDE_ALL_DRIVERS select EC_GOOGLE_CHROMEEC + select EC_GOOGLE_CHROMEEC_AP_WATCHDOG_FLAG select EC_GOOGLE_CHROMEEC_BOARDID select EC_GOOGLE_CHROMEEC_SPI select MAINBOARD_HAS_SPI_TPM_CR50 if VBOOT diff --git a/src/mainboard/google/kukui/early_init.c b/src/mainboard/google/kukui/early_init.c index a16a335..9495af3 100644 --- a/src/mainboard/google/kukui/early_init.c +++ b/src/mainboard/google/kukui/early_init.c @@ -25,11 +25,11 @@
void mainboard_early_init(void) { - mt8183_early_init(); - /* Turn on real eMMC and allow communication to EC. */ gpio_output(BOOTBLOCK_EN_L, 1);
+ mt8183_early_init(); + setup_chromeos_gpios();
/* Declare we are in S0 */
You-Cheng Syu has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/31844 )
Change subject: google/kukui: Enable EC_GOOGLE_CHROMEEC_AP_WATCHDOG_FLAG ......................................................................
google/kukui: Enable EC_GOOGLE_CHROMEEC_AP_WATCHDOG_FLAG
Kukui AP doesn't remember if the last AP reset was due to AP watchdog. We need to enable EC_GOOGLE_CHROMEEC_AP_WATCHDOG_FLAG so that it will query the reset reason from EC during watchdog initialization.
Besides, we should set BOOTBLOCK_EN_L before mtk_wdt_init so that we can communicate with EC at the time.
BUG=b:109900671,b:118654976 BRANCH=none TEST=1. run 'mosys eventlog clear; stop daisydog; echo > /dev/watchdog' 2. wait for watchdog reset 3. see 'WDT: Last reset was hardware watchdog' in AP console 4. check 'mosys eventlog list | grep watchdog'
Change-Id: I053cc7664bbaf0d3fcae26ba9481a0ad700dca90 Signed-off-by: You-Cheng Syu youcheng@google.com --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/early_init.c 2 files changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/31844/2
Hello Julius Werner, Hung-Te Lin, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31844
to look at the new patch set (#3).
Change subject: google/kukui: Enable CHROMEOS_USE_EC_WATCHDOG_FLAG ......................................................................
google/kukui: Enable CHROMEOS_USE_EC_WATCHDOG_FLAG
Kukui AP doesn't remember if the last AP reset was due to AP watchdog. We need to enable CHROMEOS_USE_EC_WATCHDOG_FLAG so that it will query the reset reason from EC.
BUG=b:109900671,b:118654976 BRANCH=none TEST=1. run 'mosys eventlog clear; stop daisydog; echo > /dev/watchdog' 2. wait for watchdog reset 3. check 'mosys eventlog list | grep watchdog'
Change-Id: I053cc7664bbaf0d3fcae26ba9481a0ad700dca90 Signed-off-by: You-Cheng Syu youcheng@google.com --- M src/mainboard/google/kukui/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/31844/3
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31844 )
Change subject: google/kukui: Enable CHROMEOS_USE_EC_WATCHDOG_FLAG ......................................................................
Patch Set 4: Code-Review+2
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31844 )
Change subject: google/kukui: Enable CHROMEOS_USE_EC_WATCHDOG_FLAG ......................................................................
Patch Set 7:
hi yuping, please check why this still failed and fix if applicable. Or just retry.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31844 )
Change subject: google/kukui: Enable CHROMEOS_USE_EC_WATCHDOG_FLAG ......................................................................
Patch Set 7: Code-Review+1
Yu-Ping Wu has uploaded a new patch set (#11) to the change originally created by You-Cheng Syu. ( https://review.coreboot.org/c/coreboot/+/31844 )
Change subject: google/kukui: Enable CHROMEOS_USE_EC_WATCHDOG_FLAG ......................................................................
google/kukui: Enable CHROMEOS_USE_EC_WATCHDOG_FLAG
Kukui AP doesn't remember if the last AP reset was due to AP watchdog. We need to enable CHROMEOS_USE_EC_WATCHDOG_FLAG so that it will query the reset reason from EC.
BUG=b:109900671,b:118654976 BRANCH=none TEST=1. run 'mosys eventlog clear; stop daisydog; echo > /dev/watchdog' 2. wait for watchdog reset 3. check 'mosys eventlog list | grep watchdog'
Change-Id: I053cc7664bbaf0d3fcae26ba9481a0ad700dca90 Signed-off-by: You-Cheng Syu youcheng@google.com --- M src/mainboard/google/kukui/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/31844/11
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31844 )
Change subject: google/kukui: Enable CHROMEOS_USE_EC_WATCHDOG_FLAG ......................................................................
Patch Set 11:
warning: (BOARD_SPECIFIC_OPTIONS) selects CHROMEOS_USE_EC_WATCHDOG_FLAG which has unmet direct dependencies (MAINBOARD_HAS_CHROMEOS && CHROMEOS)
Yu-Ping Wu has uploaded a new patch set (#12) to the change originally created by You-Cheng Syu. ( https://review.coreboot.org/c/coreboot/+/31844 )
Change subject: google/kukui: Enable CHROMEOS_USE_EC_WATCHDOG_FLAG ......................................................................
google/kukui: Enable CHROMEOS_USE_EC_WATCHDOG_FLAG
Kukui AP doesn't remember if the last AP reset was due to AP watchdog. We need to enable CHROMEOS_USE_EC_WATCHDOG_FLAG so that it will query the reset reason from EC. The depending config CHROMEOS is also enabled.
BUG=b:109900671,b:118654976 BRANCH=none TEST=1. run 'mosys eventlog clear; stop daisydog; echo > /dev/watchdog' 2. wait for watchdog reset 3. check 'mosys eventlog list | grep watchdog'
Change-Id: I053cc7664bbaf0d3fcae26ba9481a0ad700dca90 Signed-off-by: You-Cheng Syu youcheng@google.com --- M src/mainboard/google/kukui/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/31844/12
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31844 )
Change subject: google/kukui: Enable CHROMEOS_USE_EC_WATCHDOG_FLAG ......................................................................
Patch Set 12:
Patch Set 11:
warning: (BOARD_SPECIFIC_OPTIONS) selects CHROMEOS_USE_EC_WATCHDOG_FLAG which has unmet direct dependencies (MAINBOARD_HAS_CHROMEOS && CHROMEOS)
I enable CHROMEOS to resolve the warning, but I'm curious why it hasn't been enabled.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31844 )
Change subject: google/kukui: Enable CHROMEOS_USE_EC_WATCHDOG_FLAG ......................................................................
Patch Set 12: Code-Review-1
(2 comments)
https://review.coreboot.org/c/coreboot/+/31844/12/src/mainboard/google/kukui... File src/mainboard/google/kukui/Kconfig:
https://review.coreboot.org/c/coreboot/+/31844/12/src/mainboard/google/kukui... PS12, Line 22: config CHROMEOS : def_bool y no we can't do this.
CHROMEOS should be always default y on coreboot. It's chromeos (portage) that will be using CHROMEOS option.
https://review.coreboot.org/c/coreboot/+/31844/12/src/mainboard/google/kukui... PS12, Line 35: CHROMEOS_USE_EC_WATCHDOG_FLAG one alternative is
select CHROMEOS_USE_EC_WATCHDOG_FLAG if CHROMEOS
Yu-Ping Wu has uploaded a new patch set (#13) to the change originally created by You-Cheng Syu. ( https://review.coreboot.org/c/coreboot/+/31844 )
Change subject: google/kukui: Enable CHROMEOS_USE_EC_WATCHDOG_FLAG ......................................................................
google/kukui: Enable CHROMEOS_USE_EC_WATCHDOG_FLAG
Kukui AP doesn't remember if the last AP reset was due to AP watchdog. We need to enable CHROMEOS_USE_EC_WATCHDOG_FLAG so that it will query the reset reason from EC.
BUG=b:109900671,b:118654976 BRANCH=none TEST=1. run 'mosys eventlog clear; stop daisydog; echo > /dev/watchdog' 2. wait for watchdog reset 3. check 'mosys eventlog list | grep watchdog'
Change-Id: I053cc7664bbaf0d3fcae26ba9481a0ad700dca90 Signed-off-by: You-Cheng Syu youcheng@google.com --- M src/mainboard/google/kukui/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/31844/13
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31844 )
Change subject: google/kukui: Enable CHROMEOS_USE_EC_WATCHDOG_FLAG ......................................................................
Patch Set 13: Code-Review+2
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31844 )
Change subject: google/kukui: Enable CHROMEOS_USE_EC_WATCHDOG_FLAG ......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/c/coreboot/+/31844/12/src/mainboard/google/kukui... File src/mainboard/google/kukui/Kconfig:
https://review.coreboot.org/c/coreboot/+/31844/12/src/mainboard/google/kukui... PS12, Line 22: config CHROMEOS : def_bool y
no we can't do this. […]
Ack
https://review.coreboot.org/c/coreboot/+/31844/12/src/mainboard/google/kukui... PS12, Line 35: CHROMEOS_USE_EC_WATCHDOG_FLAG
one alternative is […]
Ack
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31844 )
Change subject: google/kukui: Enable CHROMEOS_USE_EC_WATCHDOG_FLAG ......................................................................
google/kukui: Enable CHROMEOS_USE_EC_WATCHDOG_FLAG
Kukui AP doesn't remember if the last AP reset was due to AP watchdog. We need to enable CHROMEOS_USE_EC_WATCHDOG_FLAG so that it will query the reset reason from EC.
BUG=b:109900671,b:118654976 BRANCH=none TEST=1. run 'mosys eventlog clear; stop daisydog; echo > /dev/watchdog' 2. wait for watchdog reset 3. check 'mosys eventlog list | grep watchdog'
Change-Id: I053cc7664bbaf0d3fcae26ba9481a0ad700dca90 Signed-off-by: You-Cheng Syu youcheng@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/31844 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Hung-Te Lin hungte@chromium.org --- M src/mainboard/google/kukui/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Hung-Te Lin: Looks good to me, approved
diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index b4d0fda..d16e2ed 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -29,6 +29,7 @@ select SOC_MEDIATEK_MT8183 select BOARD_ROMSIZE_KB_8192 select MAINBOARD_HAS_CHROMEOS + select CHROMEOS_USE_EC_WATCHDOG_FLAG if CHROMEOS select COMMON_CBFS_SPI_WRAPPER select SPI_FLASH select FATAL_ASSERTS
-
Hung-Te Lin (Code Review) -
Patrick Georgi (Code Review)
-
You-Cheng Syu (Code Review)
-
Yu-Ping Wu (Code Review)