Change in ...coreboot[master]: nb/intel/gm45: Use a common romstage - coreboot-gerrit

5 Feb 2019


      Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31190 )
Change subject: nb/intel/gm45: Use a common romstage
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31190/2/src/mainboard/lenovo/t400/romstage.c 
File src/mainboard/lenovo/t400/romstage.c:
https://review.coreboot.org/#/c/31190/2/src/mainboard/lenovo/t400/romstage.c... 
PS2, Line 71: 	if (dock_err)
...
Console is not yet initialised in mb_setup_superio.
Yes, just put it in the code as comment to make sure future developers doesn't move it.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/31190
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I30ef7f6962aabde78b5c40e0b53bb85e01c254c1
Gerrit-Change-Number: 31190
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 05 Feb 2019 09:00:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment