Christian Walter has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34861 )
Change subject: soc/intel/cannonlake: Add PCI Id for Coffeelake E ......................................................................
soc/intel/cannonlake: Add PCI Id for Coffeelake E
Change-Id: I92e2adb32d19ff49bdef353e1f191c4960ce0d18 Signed-off-by: Christian Walter christian.walter@9elements.com --- M src/include/device/pci_ids.h M src/soc/intel/cannonlake/bootblock/report_platform.c M src/soc/intel/common/block/systemagent/systemagent.c 3 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/34861/1
diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index 1aac48e..40e06bb 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -3125,6 +3125,7 @@ #define PCI_DEVICE_ID_INTEL_CFL_ID_S_DT_4 0x3e1f #define PCI_DEVICE_ID_INTEL_CFL_ID_S_DT_8 0x3e30 #define PCI_DEVICE_ID_INTEL_CFL_ID_S_WS_8 0x3e31 +#define PCI_DEVICE_ID_INTEL_CFL_ID_E 0x3ec6 #define PCI_DEVICE_ID_INTEL_ICL_ID_U 0x8A12 #define PCI_DEVICE_ID_INTEL_ICL_ID_U_2_2 0x8A02 #define PCI_DEVICE_ID_INTEL_ICL_ID_Y 0x8A10 diff --git a/src/soc/intel/cannonlake/bootblock/report_platform.c b/src/soc/intel/cannonlake/bootblock/report_platform.c index 480b3b8..a5245d3 100644 --- a/src/soc/intel/cannonlake/bootblock/report_platform.c +++ b/src/soc/intel/cannonlake/bootblock/report_platform.c @@ -64,6 +64,7 @@ { PCI_DEVICE_ID_INTEL_CFL_ID_S_DT_4, "Coffeelake-S DT(4)" }, { PCI_DEVICE_ID_INTEL_CFL_ID_S_DT_8, "Coffeelake-S DT(8+2)" }, { PCI_DEVICE_ID_INTEL_CFL_ID_S_WS_8, "Coffeelake-S WS(8+2)" }, + { PCI_DEVICE_ID_INTEL_CFL_ID_E, "Coffeelake-E"}, { PCI_DEVICE_ID_INTEL_CML_ULT, "CometLake-U (4+2)" }, { PCI_DEVICE_ID_INTEL_CML_ULT_2_2, "CometLake-U (2+2)" }, { PCI_DEVICE_ID_INTEL_CML_ULT_6_2, "CometLake-U (6+2)" }, diff --git a/src/soc/intel/common/block/systemagent/systemagent.c b/src/soc/intel/common/block/systemagent/systemagent.c index c9abb55..1d2b293 100644 --- a/src/soc/intel/common/block/systemagent/systemagent.c +++ b/src/soc/intel/common/block/systemagent/systemagent.c @@ -362,6 +362,7 @@ PCI_DEVICE_ID_INTEL_CFL_ID_S_DT_4, PCI_DEVICE_ID_INTEL_CFL_ID_S_DT_8, PCI_DEVICE_ID_INTEL_CFL_ID_S_WS_8, + PCI_DEVICE_ID_INTEL_CFL_ID_E, PCI_DEVICE_ID_INTEL_ICL_ID_U, PCI_DEVICE_ID_INTEL_ICL_ID_U_2_2, PCI_DEVICE_ID_INTEL_ICL_ID_Y,
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34861 )
Change subject: soc/intel/cannonlake: Add PCI Id for Coffeelake E ......................................................................
Patch Set 1: Code-Review+1
Some IDs haven't been added yet and are still remaining. Would you like to add them? You can find them in 337345-002, p.19 table 2-3.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34861 )
Change subject: soc/intel/cannonlake: Add PCI Id for Coffeelake E ......................................................................
Patch Set 1: -Code-Review
(1 comment)
https://review.coreboot.org/c/coreboot/+/34861/1/src/include/device/pci_ids.... File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/34861/1/src/include/device/pci_ids.... PS1, Line 3128: #define PCI_DEVICE_ID_INTEL_CFL_ID_E 0x3ec6 I think, according to the document I mentioned, this should be PCI_DEVICE_ID_INTEL_CFL_ID_S_WS_6.
Hello Patrick Rudolph, Felix Singer, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34861
to look at the new patch set (#2).
Change subject: soc/intel/cannonlake: Add remaining PCI Ids for Coffeelake ......................................................................
soc/intel/cannonlake: Add remaining PCI Ids for Coffeelake
Change-Id: I92e2adb32d19ff49bdef353e1f191c4960ce0d18 Signed-off-by: Christian Walter christian.walter@9elements.com --- M src/include/device/pci_ids.h M src/soc/intel/cannonlake/bootblock/report_platform.c M src/soc/intel/common/block/systemagent/systemagent.c 3 files changed, 24 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/34861/2
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34861 )
Change subject: soc/intel/cannonlake: Add remaining PCI Ids for Coffeelake ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34861/1/src/include/device/pci_ids.... File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/34861/1/src/include/device/pci_ids.... PS1, Line 3128: #define PCI_DEVICE_ID_INTEL_CFL_ID_E 0x3ec6
I think, according to the document I mentioned, this should be PCI_DEVICE_ID_INTEL_CFL_ID_S_WS_6.
Ack
Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34861 )
Change subject: soc/intel/cannonlake: Add remaining PCI Ids for Coffeelake ......................................................................
Patch Set 2: Code-Review+2
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34861 )
Change subject: soc/intel/cannonlake: Add remaining PCI Ids for Coffeelake ......................................................................
Patch Set 2: Code-Review+1
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34861 )
Change subject: soc/intel/cannonlake: Add remaining PCI Ids for Coffeelake ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34861/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34861/2//COMMIT_MSG@7 PS2, Line 7: remaining Why remaining? Now all are listed?
Hello Patrick Rudolph, Felix Singer, Philipp Deppenwiese, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34861
to look at the new patch set (#3).
Change subject: soc/intel/cannonlake: Add more PCI Ids for Coffeelake ......................................................................
soc/intel/cannonlake: Add more PCI Ids for Coffeelake
Change-Id: I92e2adb32d19ff49bdef353e1f191c4960ce0d18 Signed-off-by: Christian Walter christian.walter@9elements.com --- M src/include/device/pci_ids.h M src/soc/intel/cannonlake/bootblock/report_platform.c M src/soc/intel/common/block/systemagent/systemagent.c 3 files changed, 24 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/34861/3
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34861 )
Change subject: soc/intel/cannonlake: Add more PCI Ids for Coffeelake ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34861/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34861/2//COMMIT_MSG@7 PS2, Line 7: remaining
Why remaining? Now all are listed?
There you go.
Patrick Rudolph has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34861 )
Change subject: soc/intel/cannonlake: Add more PCI Ids for Coffeelake ......................................................................
soc/intel/cannonlake: Add more PCI Ids for Coffeelake
Change-Id: I92e2adb32d19ff49bdef353e1f191c4960ce0d18 Signed-off-by: Christian Walter christian.walter@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34861 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Philipp Deppenwiese zaolin.daisuki@gmail.com Reviewed-by: Felix Singer felixsinger@posteo.net --- M src/include/device/pci_ids.h M src/soc/intel/cannonlake/bootblock/report_platform.c M src/soc/intel/common/block/systemagent/systemagent.c 3 files changed, 24 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Philipp Deppenwiese: Looks good to me, approved Felix Singer: Looks good to me, but someone else must approve
diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index 1aac48e..3ac6560 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -3119,12 +3119,20 @@ #define PCI_DEVICE_ID_INTEL_WHL_ID_W_4 0x3E34 #define PCI_DEVICE_ID_INTEL_WHL_ID_W_2 0x3E35 #define PCI_DEVICE_ID_INTEL_CFL_ID_U 0x3ED0 +#define PCI_DEVICE_ID_INTEL_CFL_ID_U_2 0x3ECC #define PCI_DEVICE_ID_INTEL_CFL_ID_H 0x3ec4 +#define PCI_DEVICE_ID_INTEL_CFL_ID_H_4 0x3e10 #define PCI_DEVICE_ID_INTEL_CFL_ID_H_8 0x3e20 #define PCI_DEVICE_ID_INTEL_CFL_ID_S 0x3ec2 +#define PCI_DEVICE_ID_INTEL_CFL_ID_S_DT_2 0x3e0f #define PCI_DEVICE_ID_INTEL_CFL_ID_S_DT_4 0x3e1f #define PCI_DEVICE_ID_INTEL_CFL_ID_S_DT_8 0x3e30 +#define PCI_DEVICE_ID_INTEL_CFL_ID_S_WS_4 0x3e18 +#define PCI_DEVICE_ID_INTEL_CFL_ID_S_WS_6 0x3ec6 #define PCI_DEVICE_ID_INTEL_CFL_ID_S_WS_8 0x3e31 +#define PCI_DEVICE_ID_INTEL_CFL_ID_S_S_4 0x3e33 +#define PCI_DEVICE_ID_INTEL_CFL_ID_S_S_6 0x3eca +#define PCI_DEVICE_ID_INTEL_CFL_ID_S_S_8 0x3e32 #define PCI_DEVICE_ID_INTEL_ICL_ID_U 0x8A12 #define PCI_DEVICE_ID_INTEL_ICL_ID_U_2_2 0x8A02 #define PCI_DEVICE_ID_INTEL_ICL_ID_Y 0x8A10 diff --git a/src/soc/intel/cannonlake/bootblock/report_platform.c b/src/soc/intel/cannonlake/bootblock/report_platform.c index 480b3b8..de2feaf 100644 --- a/src/soc/intel/cannonlake/bootblock/report_platform.c +++ b/src/soc/intel/cannonlake/bootblock/report_platform.c @@ -56,14 +56,22 @@ { PCI_DEVICE_ID_INTEL_CNL_ID_U, "Cannonlake-U" }, { PCI_DEVICE_ID_INTEL_CNL_ID_Y, "Cannonlake-Y" }, { PCI_DEVICE_ID_INTEL_CFL_ID_U, "Coffeelake U (4+3e)" }, + { PCI_DEVICE_ID_INTEL_CFL_ID_U_2, "Coffeelake U (2)" }, { PCI_DEVICE_ID_INTEL_WHL_ID_W_4, "Whiskeylake W (4+2)" }, { PCI_DEVICE_ID_INTEL_WHL_ID_W_2, "Whiskeylake W (2+2)" }, { PCI_DEVICE_ID_INTEL_CFL_ID_H, "Coffeelake-H" }, + { PCI_DEVICE_ID_INTEL_CFL_ID_H_4, "Coffeelake-H (4)" }, { PCI_DEVICE_ID_INTEL_CFL_ID_H_8, "Coffeelake-H (8+2)" }, { PCI_DEVICE_ID_INTEL_CFL_ID_S, "Coffeelake-S" }, + { PCI_DEVICE_ID_INTEL_CFL_ID_S_DT_2, "Coffeelake-S DT(2)" }, { PCI_DEVICE_ID_INTEL_CFL_ID_S_DT_4, "Coffeelake-S DT(4)" }, { PCI_DEVICE_ID_INTEL_CFL_ID_S_DT_8, "Coffeelake-S DT(8+2)" }, + { PCI_DEVICE_ID_INTEL_CFL_ID_S_WS_4, "Coffeelake-S WS(4+2)" }, + { PCI_DEVICE_ID_INTEL_CFL_ID_S_WS_6, "Coffeelake-S WS(6+2)" }, { PCI_DEVICE_ID_INTEL_CFL_ID_S_WS_8, "Coffeelake-S WS(8+2)" }, + { PCI_DEVICE_ID_INTEL_CFL_ID_S_S_4, "Coffeelake-S S(4)" }, + { PCI_DEVICE_ID_INTEL_CFL_ID_S_S_6, "Coffeelake-S S(6)" }, + { PCI_DEVICE_ID_INTEL_CFL_ID_S_S_8, "Coffeelake-S S(8)" }, { PCI_DEVICE_ID_INTEL_CML_ULT, "CometLake-U (4+2)" }, { PCI_DEVICE_ID_INTEL_CML_ULT_2_2, "CometLake-U (2+2)" }, { PCI_DEVICE_ID_INTEL_CML_ULT_6_2, "CometLake-U (6+2)" }, diff --git a/src/soc/intel/common/block/systemagent/systemagent.c b/src/soc/intel/common/block/systemagent/systemagent.c index c9abb55..b7964e6 100644 --- a/src/soc/intel/common/block/systemagent/systemagent.c +++ b/src/soc/intel/common/block/systemagent/systemagent.c @@ -356,12 +356,20 @@ PCI_DEVICE_ID_INTEL_KBL_ID_DT, PCI_DEVICE_ID_INTEL_KBL_ID_DT_2, PCI_DEVICE_ID_INTEL_CFL_ID_U, + PCI_DEVICE_ID_INTEL_CFL_ID_U_2, PCI_DEVICE_ID_INTEL_CFL_ID_H, + PCI_DEVICE_ID_INTEL_CFL_ID_H_4, PCI_DEVICE_ID_INTEL_CFL_ID_H_8, PCI_DEVICE_ID_INTEL_CFL_ID_S, + PCI_DEVICE_ID_INTEL_CFL_ID_S_DT_2, PCI_DEVICE_ID_INTEL_CFL_ID_S_DT_4, PCI_DEVICE_ID_INTEL_CFL_ID_S_DT_8, + PCI_DEVICE_ID_INTEL_CFL_ID_S_WS_4, + PCI_DEVICE_ID_INTEL_CFL_ID_S_WS_6, PCI_DEVICE_ID_INTEL_CFL_ID_S_WS_8, + PCI_DEVICE_ID_INTEL_CFL_ID_S_S_4, + PCI_DEVICE_ID_INTEL_CFL_ID_S_S_6, + PCI_DEVICE_ID_INTEL_CFL_ID_S_S_8, PCI_DEVICE_ID_INTEL_ICL_ID_U, PCI_DEVICE_ID_INTEL_ICL_ID_U_2_2, PCI_DEVICE_ID_INTEL_ICL_ID_Y,