Attention is currently required from: Tarun Tuli, Subrata Banik, Arthur Heymans, Werner Zeh.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69510 )
Change subject: soc/intel/alderlake/acpi.c: Don't look up coreboot CPU index
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
File src/soc/intel/alderlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/69510/comment/1e74815a_be80d78d
PS6, Line 299: cpu_index++);
How does this work for the 256th CPU? Mark resolved if not relevant question on alderlake.
src/acpi/Kconfig:config ACPI_CPU_STRING
src/acpi/Kconfig- string
src/acpi/Kconfig- default "\_SB.CP%02X"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69510
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaaaef213b32b33e3ec9f4874d576896c2335211c
Gerrit-Change-Number: 69510
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Tue, 29 Nov 2022 10:00:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment