Change in coreboot[master]: soc/mediatek: Ensure PERST# deassertion time follows the spec
Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Paul Menzel, Angel Pons, Yu-Ping Wu. Jianjun Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62933 )
Change subject: soc/mediatek: Ensure PERST# deassertion time follows the spec ......................................................................
Patch Set 12:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62933/comment/153e3176_1bea1631 PS10, Line 7: Add timestamp to measure PERST# time
Ensure PERST# deassertion time follows the spec
Done
https://review.coreboot.org/c/coreboot/+/62933/comment/bbf2d4d5_17ca4720 PS10, Line 9: Add timestamp support to measure the assertion time of PERST#.
According to the PCIe CEM specification, the deassertion of PERST# should occur at least 100ms after […]
Done
File src/soc/mediatek/common/pcie.c:
https://review.coreboot.org/c/coreboot/+/62933/comment/74daf5f7_b3f40cd6 PS10, Line 249: mtk_pcie_reset(conf->base + PCIE_RST_CTRL_REG, true);
right. […]
Done
https://review.coreboot.org/c/coreboot/+/62933/comment/8be7edc2_ae83abec PS10, Line 251: 100000
Add a local variable (maybe right above line#248) […]
Done
-
Jianjun Wang (Code Review)