Attention is currently required from: Angel Pons, Arthur Heymans, Christian Walter, Felix Singer, Julius Werner, Lean Sheng Tan, Martin L Roth, Nico Huber, ron minnich.
David Milosevic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74798?usp=email )
Change subject: arch/arm64: Add EL1/EL2/EL3 support for arm64
......................................................................
Patch Set 9:
(3 comments)
File src/arch/arm64/Kconfig:
https://review.coreboot.org/c/coreboot/+/74798/comment/6c8af8a9_0ed23f4a :
PS6, Line 30: 1 (EL1), 2 (EL2) and 3 (EL3)
These are standard Arm architectural terms (like "CPL0" on x86), I don't think we need to add more e […]
Done
https://review.coreboot.org/c/coreboot/+/74798/comment/7ca08d1b_81303cc7 :
PS6, Line 41: depends on ARCH_RAMSTAGE_ARM64
May want to add a `depends on ARM64_CURRENT_EL == 3` here, since this wouldn't work for other levels […]
Done
File src/arch/arm64/armv8/cpu.S:
https://review.coreboot.org/c/coreboot/+/74798/comment/2611b168_8cc4fc94 :
PS6, Line 87: #endif
Doing this everywhere looks pretty ugly. Can we add a macro like […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74798?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iae1c57f0846c8d0585384f7e54102a837e701e7e
Gerrit-Change-Number: 74798
Gerrit-PatchSet: 9
Gerrit-Owner: David Milosevic
David.Milosevic@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-CC: Yidi Lin
yidilin@google.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Tue, 28 Nov 2023 16:59:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment