Attention is currently required from: Alexander Couzens, Brandon McDonnell.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67919?usp=email )
Change subject: Resolve GPI/GPIO dysphoria
......................................................................
Patch Set 6: Code-Review-1
(2 comments)
Patchset:
PS6:
GPIO is often how this is referred to in the datasheet.
File src/southbridge/intel/ibexpeak/pch.h:
https://review.coreboot.org/c/coreboot/+/67919/comment/efc2e96f_c97a09ae :
PS6, Line 112: GPIO_ROUT
This is actually how the registers is called in datasheet.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67919?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I00fc9e3bfbba5b849d21651b08368fa897ccb1fb
Gerrit-Change-Number: 67919
Gerrit-PatchSet: 6
Gerrit-Owner: Brandon McDonnell
bamteck@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Brandon McDonnell
bamteck@gmail.com
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Comment-Date: Mon, 08 Jan 2024 08:42:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment