Attention is currently required from: Tim Wawrzynczak, Kevin Chiu, Jimmy Su, Robert Chen, Wisley Chen.
Shon Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60275 )
Change subject: mb/google/brya/var/vell: Add MIPI camera support
......................................................................
Patch Set 4:
(4 comments)
File src/mainboard/google/brya/variants/vell/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/60275/comment/fbb244ea_a0338998
PS4, Line 133: 2
This value should be "4". […]
I fix it in here
https://review.coreboot.org/c/coreboot/+/60276
thank you
https://review.coreboot.org/c/coreboot/+/60275/comment/6c20ec96_10764fa6
PS4, Line 235: OVTI2740
Please change the HID name as "OVTI8856"
Done
https://review.coreboot.org/c/coreboot/+/60275/comment/f770be9e_5d621a23
PS4, Line 238: Ov 2740 Camera
The chip name should be aligned with driver. […]
Done
https://review.coreboot.org/c/coreboot/+/60275/comment/057869c0_a192bcc5
PS4, Line 242: register "ssdb.lanes_used" = "2"
: register "ssdb.link_used" = "1"
: register "num_freq_entries" = "1"
: register "link_freq[0]" = "DEFAULT_LINK_FREQ"
please correct to the below content to align with driver settings […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60275
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0fa77b07c52541446e83c479ff9a409a99175622
Gerrit-Change-Number: 60275
Gerrit-PatchSet: 4
Gerrit-Owner: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jimmy Su
jimmy.su@intel.corp-partner.google.com
Gerrit-CC: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Attention: Jimmy Su
jimmy.su@intel.corp-partner.google.com
Gerrit-Attention: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Attention: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 22 Dec 2021 09:25:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jimmy Su
jimmy.su@intel.corp-partner.google.com
Gerrit-MessageType: comment