Change in ...coreboot[master]: src/drivers/intel/fsp2_0: Added FSP_S component to VBOOT Stage Verifi...
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32155 )
Change subject: src/drivers/intel/fsp2_0: Added FSP_S component to VBOOT Stage Verification. FSP_S component will be verified in RAMSTAGE. ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/#/c/32155/1/src/drivers/intel/fsp2_0/silicon_ini... File src/drivers/intel/fsp2_0/silicon_init.c:
https://review.coreboot.org/#/c/32155/1/src/drivers/intel/fsp2_0/silicon_ini... PS1, Line 29: * overriden by VBOOT mechanism. 'overriden' may be misspelled - perhaps 'overridden'?
https://review.coreboot.org/#/c/32155/1/src/drivers/intel/fsp2_0/silicon_ini... PS1, Line 32: const char * name) "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/32155/1/src/drivers/intel/fsp2_0/silicon_ini... PS1, Line 34: /* no op */ code indent should use tabs where possible
https://review.coreboot.org/#/c/32155/1/src/drivers/intel/fsp2_0/silicon_ini... PS1, Line 43: printk (BIOS_ERR, "ERROR: Unable to locate %s\n", prog_name(fsps)); line over 80 characters
https://review.coreboot.org/#/c/32155/1/src/drivers/intel/fsp2_0/silicon_ini... PS1, Line 43: printk (BIOS_ERR, "ERROR: Unable to locate %s\n", prog_name(fsps)); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/32155/1/src/drivers/intel/fsp2_0/silicon_ini... PS1, Line 113: trailing whitespace
-
build bot (Jenkins) (Code Review)