View Change

6 comments:

• File src/drivers/intel/fsp2_0/silicon_init.c:

  • Patch Set #1, Line 29: * overriden by VBOOT mechanism.

    'overriden' may be misspelled - perhaps 'overridden'?

  • Patch Set #1, Line 32: const char * name)

    "foo * bar" should be "foo *bar"

  • Patch Set #1, Line 34: /* no op */

    code indent should use tabs where possible

  • Patch Set #1, Line 43: printk (BIOS_ERR, "ERROR: Unable to locate %s\n", prog_name(fsps));

    line over 80 characters

  • Patch Set #1, Line 43: printk (BIOS_ERR, "ERROR: Unable to locate %s\n", prog_name(fsps));

    space prohibited between function name and open parenthesis '('

  • Patch Set #1, Line 113:

    trailing whitespace

To view, visit change 32155. To unsubscribe, or for help writing mail filters, visit settings.