[XS] Change in coreboot[main]: arch/x86/include/smm: use pm_acpi_smi_cmd_port - coreboot-gerrit

5 Jan 2024


      Attention is currently required from: Arthur Heymans, Jérémy Compostella.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79568?usp=email )
Change subject: arch/x86/include/smm: use pm_acpi_smi_cmd_port
......................................................................
Patch Set 5:
(1 comment)
This change is ready for review.
File src/arch/x86/include/smm.h:
https://review.coreboot.org/c/coreboot/+/79568/comment/06cd31fa_1627a774 :
PS3, Line 17: 		"outb %b0, %3"
...
oh, if i had seen your comment before working on this, i'd have recycled this chage id for CB:79766. […]
looked into this and now understood how things were working. thanks or the pointer and the explanation
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/79568?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icb79c91cfcd75db760bd80cff7f3d0400d1f16cd
Gerrit-Change-Number: 79568
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 05 Jan 2024 22:41:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment