Attention is currently required from: Matt DeVillier, Paul Menzel, Michael Niewöhner. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51550 )
Change subject: documentation: Add documentation for Purism Librem 14 ......................................................................
Patch Set 5: Code-Review+1
(6 comments)
File Documentation/mainboard/purism/librem_14.md:
https://review.coreboot.org/c/coreboot/+/51550/comment/5ec64998_ba1800ca PS3, Line 58: the PCI device is not visible/active (as it is in Purism's release builds).
there is no Kconfig option for this
Ack
File Documentation/mainboard/purism/librem_14.md:
https://review.coreboot.org/c/coreboot/+/51550/comment/38e8f02b_76e079ea PS4, Line 74: sodimm
SO-DIMM
Done
File Documentation/mainboard/purism/librem_14.md:
https://review.coreboot.org/c/coreboot/+/51550/comment/d39830fc_7770ac82 PS5, Line 42: nit: trailing space
https://review.coreboot.org/c/coreboot/+/51550/comment/8bd7c06d_34ceffdb PS5, Line 74: socket nit: slot?
File Documentation/mainboard/purism/librem_14_ec_flash.jpg:
PS5: Can this be compressed more, or does quality suffer too much?
File Documentation/mainboard/purism/librem_14_flash.jpg:
PS5: Same here
-
Angel Pons (Code Review)