Attention is currently required from: Nico Huber, Martin Roth, Angel Pons, Julius Werner, Arthur Heymans.
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51059 )
Change subject: ec/hp/kbc1126: Reserve EC pointers in bootblock.ld
......................................................................
Patch Set 5:
(1 comment)
File src/ec/hp/kbc1126/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/51059/comment/505be805_74ca3fc7
PS1, Line 3: bootblock-y += ec_pointers.S
I still want to reserve space for the EC pointers, so that one can manually patch them in later. […]
How about my approach at https://review.coreboot.org/c/coreboot/+/51671 ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51059
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia143cb1b64b89aa7fe2d7348a648394ba936b97c
Gerrit-Change-Number: 51059
Gerrit-PatchSet: 5
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bill XIE
persmule@hardenedlinux.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sat, 20 Mar 2021 18:28:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment