Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46018 )
Change subject: soc/intel: convert XTAL frequency constant to Kconfig
......................................................................
Patch Set 10: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/46018/10/src/soc/intel/common/block...
File src/soc/intel/common/block/cpu/Kconfig:
https://review.coreboot.org/c/coreboot/+/46018/10/src/soc/intel/common/block...
PS10, Line 102: config SOC_INTEL_COMMON_BLOCK_XTAL_CLOCK_HZ
It reads a bit odd. It's about the CPU block, but you omit `CPU`. So maybe
also remove the `COMMON_BLOCK_`?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46018
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1382dd274eeb9cb748f94c34f5d9a83880624c18
Gerrit-Change-Number: 46018
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 13 Oct 2020 20:53:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment