Attention is currently required from: Hung-Te Lin, Yu-Ping Wu, Yidi Lin. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53895 )
Change subject: soc/mediatek/mt8195: Configure eMMC and SDCard ......................................................................
Patch Set 2:
(6 comments)
File src/mainboard/google/cherry/mainboard.c:
https://review.coreboot.org/c/coreboot/+/53895/comment/76ee1253_05ce9580 PS1, Line 88: MSDC1_GPIO_MODE0_0, MSDC1_GPIO_MODE0_VALUE,
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/53895/comment/75b11910_fbaf26d3 PS1, Line 89: MSDC1_GPIO_MODE0_1, MSDC1_GPIO_MODE0_VALUE);
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/53895/comment/59ceacea_417b3d47 PS1, Line 93: MSDC1_GPIO_MODE1_0, MSDC1_GPIO_MODE1_VALUE,
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/53895/comment/8a53801c_a1fd20cd PS1, Line 94: MSDC1_GPIO_MODE1_1, MSDC1_GPIO_MODE1_VALUE,
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/53895/comment/dc3ad8a6_6ae93b40 PS1, Line 95: MSDC1_GPIO_MODE1_2, MSDC1_GPIO_MODE1_VALUE,
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/53895/comment/f08de529_b11dd324 PS1, Line 96: MSDC1_GPIO_MODE1_3, MSDC1_GPIO_MODE1_VALUE);
code indent should use tabs where possible […]
Done