Attention is currently required from: Arthur Heymans, Benjamin Doron, Jakub Czapiga, Julius Werner, Jérémy Compostella, Philipp Hug, Simon Glass, ron minnich.
Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/76591?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: Add UPL FDT handoff
......................................................................
Patch Set 24:
(2 comments)
File src/lib/upl_fdt_table.c:
https://review.coreboot.org/c/coreboot/+/76591/comment/30dbdf90_676c63db?usp... :
PS24, Line 54: header.reserve_map_offset = cpu_to_be32(ALIGN_UP(dev_tree.header_size, 16));
You can change to 8 byte alignment (as per spec), but I don't see why you would remove the ALIGN_UP. This way it is at least explicit that there is an alignment constraint.
https://review.coreboot.org/c/coreboot/+/76591/comment/3fc5b1fb_13dd6939?usp... :
PS24, Line 99: // add memory and memory-reserved nodes; TODO(benjamindoron): Some mmio instead of memory
what is the intention behind the TODO?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76591?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I36148e9de6ee992a67ec853ef5cbf1b5f83b44ae
Gerrit-Change-Number: 76591
Gerrit-PatchSet: 24
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Simon Glass
sjg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Shuo Liu
shuo.liu@intel.com
Gerrit-CC: coreboot org
coreboot.org@gmail.com
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Simon Glass
sjg@chromium.org
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Tue, 05 Nov 2024 09:57:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No