Attention is currently required from: Arthur Heymans, Christian Walter, Felix Held, Krystian Hebel, Michał Żygowski.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76954?usp=email )
Change subject: security/tpm/: turn tis_{init,open} into tis_probe
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Have we root caused what led to this problem on the Crater Lake platform? Has that issue been fixed yet?
I don't think so. I don't even know what hardware was affected and whether all related code is public.
I like `die()` better too but without ability to debug the issue adding `die()` just makes things worse. In addition to the error code, there is an error message which should be visible in the boot log. I'm counting on it drawing attention to the issue on affected platforms.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76954?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I52ad8d69d50d449f031c36b15bf70ef07986946c
Gerrit-Change-Number: 76954
Gerrit-PatchSet: 1
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 08 Aug 2023 12:18:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment