Attention is currently required from: Raul Rangel, Jason Nien, EricKY Cheng, Matt DeVillier, Martin Roth, Tim Van Patten, Eric Peers, Jason Glenesk, Caveh Jalali, Tim Wawrzynczak, Fred Reitberger, Karthikeyan Ramasubramanian, Boris Mittelberg, Felix Held.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68471 )
Change subject: common/acpi/dptc: Implement DTTS Proposal
......................................................................
Patch Set 30:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68471/comment/421dc49c_8aa31a32
PS30, Line 9: DTTS indicated Dynamic Thermal Table Switching.
: The proposal would like to develop the schematic
: for switching 6 thermal table by lid status,
: machine body mode and temperature.
: After entering the OS, the thermal table would be table A.
: If the “Motion” or “Lid-status changement” is detected.
: The thermal table would switch to laptop mode or lid-close
: mode. Once the higher environment temperatures are detected,
: the thermal table would switch to the corresponding power
: throttle table(B, D or F). Based on these table switching
: mechanisms, no matter how the end-user uses Chromebook,
: they could enjoy more humanized thermal designs.
Please reflow for 72 characters per line, and add a blank line between paragraphs.
https://review.coreboot.org/c/coreboot/+/68471/comment/314f318a_ecc45747
PS30, Line 39: Table
table
https://review.coreboot.org/c/coreboot/+/68471/comment/4366f625_742066d3
PS30, Line 39: 5. Assume Table A is current table. When the temperature
Maybe start a new paragraph, saying it’s an example.
https://review.coreboot.org/c/coreboot/+/68471/comment/72ecd019_76daab1d
PS30, Line 40: reach
reaches
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68471
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I866e5e497e2936984e713029b5f0b6d54cbc9622
Gerrit-Change-Number: 68471
Gerrit-PatchSet: 30
Gerrit-Owner: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: LeilaCY Lin
leilacy_lin@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Eric Peers
epeers@google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 04 Nov 2022 13:40:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment