Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38292 )
Change subject: coreinfo/coreinfo.c: Correct main function signature ......................................................................
coreinfo/coreinfo.c: Correct main function signature
libpayload passes argc and argv to main(), and ignoring these arguments causes a compile time error when using LTO.
Change-Id: I5d2b30158ebabe1d1534a9684874018483ad769b Signed-off-by: Jacob Garber jgarber1@ualberta.ca --- M payloads/coreinfo/coreinfo.c 1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/38292/1
diff --git a/payloads/coreinfo/coreinfo.c b/payloads/coreinfo/coreinfo.c index 53985b2..b1017f0 100644 --- a/payloads/coreinfo/coreinfo.c +++ b/payloads/coreinfo/coreinfo.c @@ -290,8 +290,11 @@ } }
-int main(void) +int main(int argc, char **argv) { + (void)argc; + (void)argv; + int j;
if (CONFIG(LP_USB))
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38292 )
Change subject: coreinfo/coreinfo.c: Correct main function signature ......................................................................
Patch Set 2: Code-Review+1
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38292 )
Change subject: coreinfo/coreinfo.c: Correct main function signature ......................................................................
Patch Set 3: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38292 )
Change subject: coreinfo/coreinfo.c: Correct main function signature ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38292 )
Change subject: coreinfo/coreinfo.c: Correct main function signature ......................................................................
coreinfo/coreinfo.c: Correct main function signature
libpayload passes argc and argv to main(), and ignoring these arguments causes a compile time error when using LTO.
Change-Id: I5d2b30158ebabe1d1534a9684874018483ad769b Signed-off-by: Jacob Garber jgarber1@ualberta.ca Reviewed-on: https://review.coreboot.org/c/coreboot/+/38292 Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M payloads/coreinfo/coreinfo.c 1 file changed, 4 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/payloads/coreinfo/coreinfo.c b/payloads/coreinfo/coreinfo.c index 53985b2..b1017f0 100644 --- a/payloads/coreinfo/coreinfo.c +++ b/payloads/coreinfo/coreinfo.c @@ -290,8 +290,11 @@ } }
-int main(void) +int main(int argc, char **argv) { + (void)argc; + (void)argv; + int j;
if (CONFIG(LP_USB))