Attention is currently required from: Angel Pons, Arthur Heymans, Alexander Couzens, Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52070 )
Change subject: nb/intel/ironlake: Drop `pci_mmio_size`
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52070/comment/49f8a730_dbb00253
PS1, Line 9: There's no good reason to use values smaller than 2 GiB here.
Well we know one reason: I increases available DRAM in 32-bit space.
If that's a good reason, I don't know. But we should at least mention
it (and maybe add that it was fragile / not bricking is better?).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52070
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6cdce5f56bc94cca7065ee3e38af60d1de66e45c
Gerrit-Change-Number: 52070
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 02 Apr 2021 21:01:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment