Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46928 )
Change subject: cpu/x86/sipi_vector.S: Use correct suffix for bts ......................................................................
cpu/x86/sipi_vector.S: Use correct suffix for bts
The assembler is warning that the bts instruction is ambiguous, so use the correct suffix btsl. See also commit 693315160e (cpu/x86/sipi_vector.S: Use correct op suffix)
Signed-off-by: Jacob Garber jgarber1@ualberta.ca Change-Id: I2eded0af1258e90926009544683b23961d99887b --- M src/cpu/x86/sipi_vector.S 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/46928/1
diff --git a/src/cpu/x86/sipi_vector.S b/src/cpu/x86/sipi_vector.S index ba1ecb7..054f30d 100644 --- a/src/cpu/x86/sipi_vector.S +++ b/src/cpu/x86/sipi_vector.S @@ -121,7 +121,7 @@
/* Protect microcode loading. */ lock_microcode: - lock bts $0, microcode_lock + lock btsl $0, microcode_lock jc lock_microcode
load_microcode:
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46928 )
Change subject: cpu/x86/sipi_vector.S: Use correct suffix for bts ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/46928/1/src/cpu/x86/sipi_vector.S File src/cpu/x86/sipi_vector.S:
https://review.coreboot.org/c/coreboot/+/46928/1/src/cpu/x86/sipi_vector.S@1... PS1, Line 124: lock btsl $0, microcode_lock If I can scroll up and look how it's declared, why can't the assembler? ^^
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46928 )
Change subject: cpu/x86/sipi_vector.S: Use correct suffix for bts ......................................................................
cpu/x86/sipi_vector.S: Use correct suffix for bts
The assembler is warning that the bts instruction is ambiguous, so use the correct suffix btsl. See also commit 693315160e (cpu/x86/sipi_vector.S: Use correct op suffix)
Signed-off-by: Jacob Garber jgarber1@ualberta.ca Change-Id: I2eded0af1258e90926009544683b23961d99887b Reviewed-on: https://review.coreboot.org/c/coreboot/+/46928 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/cpu/x86/sipi_vector.S 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/cpu/x86/sipi_vector.S b/src/cpu/x86/sipi_vector.S index ba1ecb7..054f30d 100644 --- a/src/cpu/x86/sipi_vector.S +++ b/src/cpu/x86/sipi_vector.S @@ -121,7 +121,7 @@
/* Protect microcode loading. */ lock_microcode: - lock bts $0, microcode_lock + lock btsl $0, microcode_lock jc lock_microcode
load_microcode:
-
Jacob Garber (Code Review) -
Nico Huber (Code Review)