build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37871 )
Change subject: soc/intel/common/block: Enable PMC IPC driver in coreboot ......................................................................
Patch Set 4:
(9 comments)
https://review.coreboot.org/c/coreboot/+/37871/4/src/soc/intel/common/block/... File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/37871/4/src/soc/intel/common/block/... PS4, Line 37: #define PMC_IPC_STS_BUSY 1 << 0 Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/37871/4/src/soc/intel/common/block/... PS4, Line 38: #define PMC_IPC_STS_ERR 1 << 1 Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/37871/4/src/soc/intel/common/block/... PS4, Line 630: stopwatch_duration_msecs(&sw)); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37871/4/src/soc/intel/common/block/... PS4, Line 630: stopwatch_duration_msecs(&sw)); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37871/4/src/soc/intel/common/block/... PS4, Line 636: int pmc_send_ipc_cmd(uint32_t cmd, uint32_t sub, uint8_t *in, uint32_t inlen, uint32_t *out,uint32_t outlen) line over 96 characters
https://review.coreboot.org/c/coreboot/+/37871/4/src/soc/intel/common/block/... PS4, Line 636: int pmc_send_ipc_cmd(uint32_t cmd, uint32_t sub, uint8_t *in, uint32_t inlen, uint32_t *out,uint32_t outlen) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/37871/4/src/soc/intel/common/block/... PS4, Line 647: for (i = 0; i < ((inlen +3) / 4); i++) { need consistent spacing around '+' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/37871/4/src/soc/intel/common/block/... PS4, Line 650: printk(BIOS_DEBUG, "Wrote %x into pmcbase WBUF0", wbuf[i] ); space prohibited before that close parenthesis ')'
https://review.coreboot.org/c/coreboot/+/37871/4/src/soc/intel/common/block/... PS4, Line 657: if(check_ips_sts(pmcbase)) { space required before the open parenthesis '('
-
build bot (Jenkins) (Code Review)