Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39425 )
Change subject: soc/intel/xeon_sp: Add Lewisburg defs for common/gpio driver
......................................................................
Patch Set 18:
Patch Set 18:
we got some preliminary results and they look promising. However we haven't yet have luck with running it under inteltool to see if inteltool picks up all the pads correctly. stay tuned.
Ok, thx. Please use inteltool with the latest changes for testing from https://review.coreboot.org/c/coreboot/+/40044
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39425
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idde32fdd53f1966e3ba6b7f5598ae8f51488d5a5
Gerrit-Change-Number: 39425
Gerrit-PatchSet: 18
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 03 Apr 2020 17:51:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment