[M] Change in coreboot[master]: soc/amd/common/xhci: Add support for logging XHCI wake events

[Martin Roth (Code Review)]

Attention is currently required from: Robert Zieba, Jason Glenesk, Raul Rangel, Matt DeVillier, Angel Pons, Fred Reitberger, Karthik Ramasubramanian, Felix Held.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67936 )

Change subject: soc/amd/common/xhci: Add support for logging XHCI wake events
......................................................................

Patch Set 7:

(4 comments)

File src/soc/amd/common/block/acpi/elog.c:

https://review.coreboot.org/c/coreboot/+/67936/comment/ade14c60_c1796d35 
PS7, Line 34: if (i == XHCI_GEVENT)
can you use if (CONFIG(SOC_AMD_COMMON_BLOCK_XHCI_ELOG) && i == XHCI_GEVENT) so that this gets optimized out if SOC_AMD_COMMON_BLOCK_XHCI_ELOG isn't enabled?  I believe that you shouldn't need the empty declaration for soc_xhci_log_wake_events at that point.

File src/soc/amd/common/block/include/amdblocks/xhci.h:

https://review.coreboot.org/c/coreboot/+/67936/comment/b004829f_2bf555f3 
PS7, Line 19: #if CONFIG(SOC_AMD_COMMON_BLOCK_XHCI_ELOG) && ENV_SMM
We shouldn't ever need to hide the declarations this way.

File src/soc/amd/common/block/xhci/Kconfig:

https://review.coreboot.org/c/coreboot/+/67936/comment/ca4c3a33_09797cec 
PS7, Line 9: && SMM_PCI_BAR_STORE
instead of making SMM_PCI_BAR_STORE a dependency, why not select it if this option is enabled?

https://review.coreboot.org/c/coreboot/+/67936/comment/360f5e24_ea339469 
PS7, Line 9: SOC_AMD_COMMON_BLOCK_XHCI
I'd recommend that you use an `if SOC_AMD_COMMON_BLOCK_XHCI ...  endif` block around this instead of a dependency.  There's no difference now, but if anything else gets added, it makes it cleaner.