Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/58060 )
Change subject: ec/google/chromeec: Update google_chromeec_usb_pd_get_info() ......................................................................
ec/google/chromeec: Update google_chromeec_usb_pd_get_info()
google_chromeec_usb_pd_get_info() is used in ec.c only. Make it static and drop from ec.h.
BUG=b:192947843
Signed-off-by: Derek Huang derek.huang@intel.corp-partner.google.com Change-Id: I4b3df4223d5c26ea1c1a52b26f7d49fa4c947de8 Reviewed-on: https://review.coreboot.org/c/coreboot/+/58060 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/ec.h 2 files changed, 2 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c index e27ad9e..642c313 100644 --- a/src/ec/google/chromeec/ec.c +++ b/src/ec/google/chromeec/ec.c @@ -1477,7 +1477,8 @@ return (google_chromeec_get_current_image() == EC_IMAGE_RO); }
-int google_chromeec_usb_pd_get_info(int port, bool *ufp, bool *dbg_acc, +/* Returns data role and type of device connected */ +static int google_chromeec_usb_pd_get_info(int port, bool *ufp, bool *dbg_acc, bool *active_cable, uint8_t *dp_mode) { struct ec_params_usb_pd_control pd_control = { diff --git a/src/ec/google/chromeec/ec.h b/src/ec/google/chromeec/ec.h index f4090fe..131a460 100644 --- a/src/ec/google/chromeec/ec.h +++ b/src/ec/google/chromeec/ec.h @@ -33,9 +33,6 @@ * usb capability, dp capability, cable type, etc */ int google_chromeec_usb_get_pd_mux_info(int port, uint8_t *flags); -/* Returns data role and type of device connected */ -int google_chromeec_usb_pd_get_info(int port, bool *ufp, bool *dbg_acc, - bool *active_cable, uint8_t *dp_mode); /* Poll (up to `timeout_ms` ms) for DisplayPort to be ready * Return: -1: Error. 0: Timeout. * >=1: Bitmask of the ports that DP device is connected