Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63089 )
Change subject: soc/mediatek/mt8186: Fix pmif setting for low power mode ......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63089/comment/272356a8_b2b3ee5b PS2, Line 7: add pmif driver setting
Fix pmif setting for low power mode
Done
https://review.coreboot.org/c/coreboot/+/63089/comment/e005eabe_61853166 PS2, Line 9: We encounter a issue of suspend fail, and the root cause is that : the default pmif register setting is not correct for low power : mode. Therefore, we add the correct setting of pmif low power.
The current pmif register setting for low power mode is incorrect, which is causing suspend failure. […]
Done
File src/soc/mediatek/mt8186/include/soc/pmif.h:
https://review.coreboot.org/c/coreboot/+/63089/comment/cf9946c8_137df3b0 PS2, Line 8: _
MT8186
Done
https://review.coreboot.org/c/coreboot/+/63089/comment/5c19cd76_eeccf063 PS2, Line 14: spmi
Just to confirm, does "spmi" mean System Power Management Interface?
yes
-
Rex-BC Chen (Code Review)