Change in ...coreboot[master]: drivers/i2c: Add device info to cbmem log

[EricR Lai (Code Review)]

EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33432

Change subject: drivers/i2c: Add device info to cbmem log
......................................................................

drivers/i2c: Add device info to cbmem log

Add some device I2C info to cbmem log

BUG=none
BRANCH=none
TEST=Boot up and check cbmem -c can find the SAR i2c info

Signed-off-by: Eric Lai 
Change-Id: Ia143932bb660ed2c2cea76310f11ede2b727adf4
---
M src/drivers/i2c/sx9310/sx9310.c
1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/33432/1

diff --git a/src/drivers/i2c/sx9310/sx9310.c b/src/drivers/i2c/sx9310/sx9310.c
index aafd7c7..8157874 100644
--- a/src/drivers/i2c/sx9310/sx9310.c
+++ b/src/drivers/i2c/sx9310/sx9310.c
@@ -15,6 +15,7 @@

#include <arch/acpi_device.h>
 #include <arch/acpigen.h>
+#include <console/console.h>
 #include <device/i2c_simple.h>
 #include <device/device.h>
 #include <device/path.h>
@@ -74,6 +75,9 @@

acpigen_pop_len(); /* Device */
    acpigen_pop_len(); /* Scope */
+
+	printk(BIOS_INFO, "%s: %s at %s\n", acpi_device_path(dev),
+	       config->desc ? : dev->chip_ops->name, dev_path(dev));
 }

#undef REGISTER

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33432 )

Change subject: drivers/i2c: Add device info to cbmem log
......................................................................

Patch Set 1:

Add some log for debug usage.

Change in ...coreboot[master]: drivers/i2c/sx9310: Add device info to cbmem log

[EricR Lai (Code Review)]

Hello Duncan Laurie, build bot (Jenkins), Furquan Shaikh, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33432

to look at the new patch set (#3).

Change subject: drivers/i2c/sx9310: Add device info to cbmem log
......................................................................

drivers/i2c/sx9310: Add device info to cbmem log

Add some I2C device info to cbmem log

BUG=none
BRANCH=none
TEST=Boot up and check cbmem -c can find the SAR i2c info

Signed-off-by: Eric Lai 
Change-Id: Ia143932bb660ed2c2cea76310f11ede2b727adf4
---
M src/drivers/i2c/sx9310/sx9310.c
1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/33432/3

Change in ...coreboot[master]: drivers/i2c/sx9310: Add device info to cbmem log

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33432 )

Change subject: drivers/i2c/sx9310: Add device info to cbmem log
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/33432/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/33432/3//COMMIT_MSG@7 
PS3, Line 7:  Add device info to cbmem log
"Print I2C SAR device info"? It is not just adding it to cbmem log.

Change in ...coreboot[master]: drivers/i2c/sx9310: Add device info to cbmem log

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33432 )

Change subject: drivers/i2c/sx9310: Add device info to cbmem log
......................................................................

Patch Set 3:
> Patch Set 3:
>
> (1 comment)

What should be the proper comment? I can change it.

Change in ...coreboot[master]: drivers/i2c/sx9310: Add device info to cbmem log

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33432 )

Change subject: drivers/i2c/sx9310: Add device info to cbmem log
......................................................................

Patch Set 3:
> Patch Set 3:
> > Patch Set 3:
> >
> > (1 comment)
>
> What should be the proper comment? I can change it.

Just say "Print I2C SAR device info"

Change in ...coreboot[master]: drivers/i2c/sx9310: Print I2C SAR device info

[EricR Lai (Code Review)]

Hello Duncan Laurie, build bot (Jenkins), Furquan Shaikh, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33432

to look at the new patch set (#4).

Change subject: drivers/i2c/sx9310: Print I2C SAR device info
......................................................................

drivers/i2c/sx9310: Print I2C SAR device info

Print I2C SAR device info to cbmem log

BUG=none
BRANCH=none
TEST=Boot up and check cbmem -c can find the SAR I2C info

Signed-off-by: Eric Lai 
Change-Id: Ia143932bb660ed2c2cea76310f11ede2b727adf4
---
M src/drivers/i2c/sx9310/sx9310.c
1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/33432/4

Change in ...coreboot[master]: drivers/i2c/sx9310: Print I2C SAR device info

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33432 )

Change subject: drivers/i2c/sx9310: Print I2C SAR device info
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/33432/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/33432/3//COMMIT_MSG@7 
PS3, Line 7:  Add device info to cbmem log
> "Print I2C SAR device info"? It is not just adding it to cbmem log.

Done

Change in ...coreboot[master]: drivers/i2c/sx9310: Print I2C SAR device info

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33432 )

Change subject: drivers/i2c/sx9310: Print I2C SAR device info
......................................................................

Patch Set 4: Code-Review+2

Change in ...coreboot[master]: drivers/i2c/sx9310: Print I2C SAR device info

[Furquan Shaikh (Code Review)]

Furquan Shaikh has uploaded a new patch set (#5) to the change originally created by EricR Lai. ( https://review.coreboot.org/c/coreboot/+/33432 )

Change subject: drivers/i2c/sx9310: Print I2C SAR device info
......................................................................

drivers/i2c/sx9310: Print I2C SAR device info

Print I2C SAR device info so that it is available in cbmem logs.

BUG=none
BRANCH=none
TEST=Boot up and check cbmem -c can find the SAR I2C info

Signed-off-by: Eric Lai 
Change-Id: Ia143932bb660ed2c2cea76310f11ede2b727adf4
---
M src/drivers/i2c/sx9310/sx9310.c
1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/33432/5

Change in ...coreboot[master]: drivers/i2c/sx9310: Print I2C SAR device info

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33432 )

Change subject: drivers/i2c/sx9310: Print I2C SAR device info
......................................................................

Patch Set 5: Code-Review+2

Change in ...coreboot[master]: drivers/i2c/sx9310: Print I2C SAR device info

[Furquan Shaikh (Code Review)]

Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33432 )

Change subject: drivers/i2c/sx9310: Print I2C SAR device info
......................................................................

drivers/i2c/sx9310: Print I2C SAR device info

Print I2C SAR device info so that it is available in cbmem logs.

BUG=none
BRANCH=none
TEST=Boot up and check cbmem -c can find the SAR I2C info

Signed-off-by: Eric Lai 
Change-Id: Ia143932bb660ed2c2cea76310f11ede2b727adf4
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33432
Reviewed-by: Furquan Shaikh 
Tested-by: build bot (Jenkins) 
---
M src/drivers/i2c/sx9310/sx9310.c
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved
  EricR Lai: Looks good to me, approved

diff --git a/src/drivers/i2c/sx9310/sx9310.c b/src/drivers/i2c/sx9310/sx9310.c
index aafd7c7..8157874 100644
--- a/src/drivers/i2c/sx9310/sx9310.c
+++ b/src/drivers/i2c/sx9310/sx9310.c
@@ -15,6 +15,7 @@

#include <arch/acpi_device.h>
 #include <arch/acpigen.h>
+#include <console/console.h>
 #include <device/i2c_simple.h>
 #include <device/device.h>
 #include <device/path.h>
@@ -74,6 +75,9 @@

acpigen_pop_len(); /* Device */
    acpigen_pop_len(); /* Scope */
+
+	printk(BIOS_INFO, "%s: %s at %s\n", acpi_device_path(dev),
+	       config->desc ? : dev->chip_ops->name, dev_path(dev));
 }

#undef REGISTER