Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44492 )
Change subject: intel/common: Add new mmc apis
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/44492/2/src/soc/intel/common/block/...
File src/soc/intel/common/block/scs/mmc.c:
https://review.coreboot.org/c/coreboot/+/44492/2/src/soc/intel/common/block/...
PS2, Line 27: EMMC_TX_CMD_CNTL_OFFSET);
nit: these lines should fit in 96 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44492
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie70f14d95f81d30360f5a68fbb34b50425e98ece
Gerrit-Change-Number: 44492
Gerrit-PatchSet: 2
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.corp-partner.google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 04 Oct 2020 15:35:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment