Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46109 )
Change subject: util: update max line length to 96 ......................................................................
util: update max line length to 96
Modify checkpatch to allow 96 column line length.
BUG=b:170217700 TEST=Modify a file to extend a line to 96 characters and verify that checkpatch allows it to be committed.
Change-Id: I98c50a1f87be043a31cc9d0e9aac915be08c0acb Signed-off-by: Nick Vaccaro nvaccaro@google.com --- M util/lint/checkpatch.pl 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/46109/1
diff --git a/util/lint/checkpatch.pl b/util/lint/checkpatch.pl index 1affdb7..c6cbe69 100755 --- a/util/lint/checkpatch.pl +++ b/util/lint/checkpatch.pl @@ -51,7 +51,7 @@ my @exclude = (); #coreboot my $help = 0; my $configuration_file = ".checkpatch.conf"; -my $max_line_length = 80; +my $max_line_length = 96; my $ignore_perl_version = 0; my $minimum_perl_version = 5.10.0; my $min_conf_desc_length = 4;
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46109 )
Change subject: util: update max line length to 96 ......................................................................
Patch Set 1: Code-Review-2
CB:43324 CB:38677 CB:34386 CB:33405
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46109 )
Change subject: util: update max line length to 96 ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46109/1/util/lint/checkpatch.pl File util/lint/checkpatch.pl:
https://review.coreboot.org/c/coreboot/+/46109/1/util/lint/checkpatch.pl@54 PS1, Line 54: my $max_line_length = 96; This is not correct. You should be updating .checkpatch.conf to set max-line-length to 96 instead of directly changing this file.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46109 )
Change subject: util: update max line length to 96 ......................................................................
Patch Set 1:
As Julius wrote, I did the same change in I2b5c5d4cf9f0534298d00e76173cd448e8e13281 [1], and it turned out my hooks were outdated. Though I still think it’d be better if we checked the script to the new length limit.
[1]: https://review.coreboot.org/c/coreboot/+/38677
Nick Vaccaro has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/46109 )
Change subject: util: update max line length to 96 ......................................................................
Abandoned
duplicate of cb:33405
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46109 )
Change subject: util: update max line length to 96 ......................................................................
Patch Set 1:
please see https://review.coreboot.org/c/coreboot/+/46118 Thx
-
Furquan Shaikh (Code Review) -
HAOUAS Elyes (Code Review)
-
Julius Werner (Code Review)
-
Nick Vaccaro (Code Review)
-
Paul Menzel (Code Review)