[S] Change in coreboot[master]: soc/intel/{tgl,adl}: Hook up D3ColdEnable UPD to D3COLD_SUPPORT

[Michael Niewöhner (Code Review)]

Attention is currently required from: Sean Rhodes.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72800 )

Change subject: soc/intel/{tgl,adl}: Hook up D3ColdEnable UPD to D3COLD_SUPPORT
......................................................................

Patch Set 8:

(1 comment)

File src/device/Kconfig:

https://review.coreboot.org/c/coreboot/+/72800/comment/7f324c7c_4cd7a5c7 
PS4, Line 1004: Don't support D3Cold"
              : 	default n if NO_S0IX_SUPPORT
> Michael, […]

1. You were the only one giving +2. You can't *assume* that changes have been reviewed just because some random period of time has passed. Review will always be signalled by +1 or +2. You even submitted the patches without waiting for the tests to finish. At least nothing broke...

2. As I said, it's not about a tiny problem here. Check the other comments. Anyway, IMHO the whole situation qualifies for a revert. However, I'm not the (only) one who is going to decide that. This will be handled by the review process as well and I'm sure other people will share their opinion soon.