[S] Change in coreboot[master]: sb/intel: Use boolean for c4onc3_enable - coreboot-gerrit

30 Nov 2022


      Attention is currently required from: Stefan Ott, Evgeny Zinoviev, Alexander Couzens, Elyes Haouas.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70112 )
Change subject: sb/intel: Use boolean for c4onc3_enable
......................................................................
Patch Set 2: Code-Review-2
(2 comments)
Patchset:
PS2: 
Some devicetrees have it set to 0 others to 1 and both are just removed? What is this patch trying to achieve?
File src/southbridge/intel/i82801gx/chip.h:
https://review.coreboot.org/c/coreboot/+/70112/comment/6653058d_e78d8223 
PS2, Line 66: c4onc3_enable:true;
This just a weird way of writing "bool c4onc3_enable:1;" ?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/70112
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4a5ea5f71579610721c91e8a7412da615c0d150
Gerrit-Change-Number: 70112
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas ehaouas@noos.fr
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Evgeny Zinoviev me@ch1p.io
Gerrit-Reviewer: Stefan Ott coreboot@desire.ch
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Stefan Ott coreboot@desire.ch
Gerrit-Attention: Evgeny Zinoviev me@ch1p.io
Gerrit-Attention: Alexander Couzens lynxis@fe80.eu
Gerrit-Attention: Elyes Haouas ehaouas@noos.fr
Gerrit-Comment-Date: Wed, 30 Nov 2022 09:48:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment