Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46693 )
Change subject: nb/intel/haswell/gma.c: Drop unused ChromeOS include ......................................................................
nb/intel/haswell/gma.c: Drop unused ChromeOS include
Change-Id: I598fe743354ea429d6821b95be7d209a9fcf9f0c Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/haswell/gma.c 1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/46693/1
diff --git a/src/northbridge/intel/haswell/gma.c b/src/northbridge/intel/haswell/gma.c index 9627945..66c8d2d 100644 --- a/src/northbridge/intel/haswell/gma.c +++ b/src/northbridge/intel/haswell/gma.c @@ -21,10 +21,6 @@ #include "chip.h" #include "haswell.h"
-#if CONFIG(CHROMEOS) -#include <vendorcode/google/chromeos/chromeos.h> -#endif - struct gt_reg { u32 reg; u32 andmask;
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46693
to look at the new patch set (#4).
Change subject: nb/intel/haswell/gma.c: Drop unused ChromeOS include ......................................................................
nb/intel/haswell/gma.c: Drop unused ChromeOS include
Change-Id: I598fe743354ea429d6821b95be7d209a9fcf9f0c Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/haswell/gma.c 1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/46693/4
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46693
to look at the new patch set (#5).
Change subject: nb/intel/haswell/gma.c: Drop unused ChromeOS include ......................................................................
nb/intel/haswell/gma.c: Drop unused ChromeOS include
Change-Id: I598fe743354ea429d6821b95be7d209a9fcf9f0c Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/haswell/gma.c 1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/46693/5
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46693
to look at the new patch set (#7).
Change subject: nb/intel/haswell/gma.c: Drop unused ChromeOS include ......................................................................
nb/intel/haswell/gma.c: Drop unused ChromeOS include
Change-Id: I598fe743354ea429d6821b95be7d209a9fcf9f0c Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/haswell/gma.c 1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/46693/7
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46693 )
Change subject: nb/intel/haswell/gma.c: Drop unused ChromeOS include ......................................................................
Patch Set 8: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46693 )
Change subject: nb/intel/haswell/gma.c: Drop unused ChromeOS include ......................................................................
Patch Set 8: Code-Review+1
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46693 )
Change subject: nb/intel/haswell/gma.c: Drop unused ChromeOS include ......................................................................
nb/intel/haswell/gma.c: Drop unused ChromeOS include
Change-Id: I598fe743354ea429d6821b95be7d209a9fcf9f0c Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46693 Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/northbridge/intel/haswell/gma.c 1 file changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
diff --git a/src/northbridge/intel/haswell/gma.c b/src/northbridge/intel/haswell/gma.c index 9627945..66c8d2d 100644 --- a/src/northbridge/intel/haswell/gma.c +++ b/src/northbridge/intel/haswell/gma.c @@ -21,10 +21,6 @@ #include "chip.h" #include "haswell.h"
-#if CONFIG(CHROMEOS) -#include <vendorcode/google/chromeos/chromeos.h> -#endif - struct gt_reg { u32 reg; u32 andmask;