Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86373?usp=email )
Change subject: mb/google/nissa: Create meliks variant ......................................................................
mb/google/nissa: Create meliks variant
Create the meliks variant of the nissa reference board by copying the template files to a new directory named for the variant.
(Auto-Generated by create_coreboot_variant.sh version 4.5.0)
BUG=b:394359785 BRANCH=None TEST=util/abuild/abuild -p none -t google/brya -x -a make sure the build includes GOOGLE_MELIKS
Change-Id: Iff5e27ef06a44976c2724751de0f9c6d5cf6eaaf Signed-off-by: Seunghwan Kim sh_.kim@samsung.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/86373 Reviewed-by: Eric Lai ericllai@google.com Reviewed-by: Kapil Porwal kapilporwal@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Kconfig.name A src/mainboard/google/brya/variants/meliks/include/variant/ec.h A src/mainboard/google/brya/variants/meliks/include/variant/gpio.h A src/mainboard/google/brya/variants/meliks/memory/Makefile.mk A src/mainboard/google/brya/variants/meliks/memory/dram_id.generated.txt A src/mainboard/google/brya/variants/meliks/memory/mem_parts_used.txt A src/mainboard/google/brya/variants/meliks/overridetree.cb 8 files changed, 52 insertions(+), 0 deletions(-)
Approvals: Kapil Porwal: Looks good to me, approved Eric Lai: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index 0f1c3c5..fd88c1b 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -351,6 +351,12 @@ select SOC_INTEL_RAPTORLAKE select USE_UNIFIED_AP_FIRMWARE_FOR_UFS_AND_NON_UFS
+config BOARD_GOOGLE_MELIKS + select BOARD_GOOGLE_BASEBOARD_NISSA + select DRIVERS_I2C_DA7219 + select DRIVERS_INTEL_MIPI_CAMERA + select SOC_INTEL_TWINLAKE + config BOARD_GOOGLE_MITHRAX select BOARD_GOOGLE_BASEBOARD_BRYA select CHROMEOS_WIFI_SAR if CHROMEOS @@ -826,6 +832,7 @@ default 0x1 if BOARD_GOOGLE_ZYDRON default 0x0 if BOARD_GOOGLE_TELITH default 0x0 if BOARD_GOOGLE_PUJJOGATWIN + default 0x0 if BOARD_GOOGLE_MELIKS
config DRIVER_TPM_I2C_ADDR hex @@ -909,6 +916,7 @@ default 13 if BOARD_GOOGLE_ZYDRON default 13 if BOARD_GOOGLE_TELITH default 13 if BOARD_GOOGLE_PUJJOGATWIN + default 13 if BOARD_GOOGLE_MELIKS
config OVERRIDE_DEVICETREE default "variants/$(CONFIG_VARIANT_DIR)/overridetree_pujjogatwin.cb" if BOARD_GOOGLE_PUJJOGATWIN @@ -1000,6 +1008,7 @@ default "Pujjoga" if BOARD_GOOGLE_PUJJOGA default "Telith" if BOARD_GOOGLE_TELITH default "Pujjogatwin" if BOARD_GOOGLE_PUJJOGATWIN + default "Meliks" if BOARD_GOOGLE_MELIKS
config VARIANT_DIR default "agah" if BOARD_GOOGLE_AGAH @@ -1076,6 +1085,7 @@ default "pujjoga" if BOARD_GOOGLE_PUJJOGA default "telith" if BOARD_GOOGLE_TELITH default "pujjoga" if BOARD_GOOGLE_PUJJOGATWIN + default "meliks" if BOARD_GOOGLE_MELIKS
config VBOOT select VBOOT_EARLY_EC_SYNC if !(BOARD_GOOGLE_BASEBOARD_NISSA || BOARD_GOOGLE_BASEBOARD_TRULO) diff --git a/src/mainboard/google/brya/Kconfig.name b/src/mainboard/google/brya/Kconfig.name index db99d32..ac4c262 100644 --- a/src/mainboard/google/brya/Kconfig.name +++ b/src/mainboard/google/brya/Kconfig.name @@ -223,3 +223,6 @@
config BOARD_GOOGLE_TELITH bool "-> Telith" + +config BOARD_GOOGLE_MELIKS + bool "-> Meliks" diff --git a/src/mainboard/google/brya/variants/meliks/include/variant/ec.h b/src/mainboard/google/brya/variants/meliks/include/variant/ec.h new file mode 100644 index 0000000..7a2a6ff --- /dev/null +++ b/src/mainboard/google/brya/variants/meliks/include/variant/ec.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef __VARIANT_EC_H__ +#define __VARIANT_EC_H__ + +#include <baseboard/ec.h> + +#endif diff --git a/src/mainboard/google/brya/variants/meliks/include/variant/gpio.h b/src/mainboard/google/brya/variants/meliks/include/variant/gpio.h new file mode 100644 index 0000000..c4fe342 --- /dev/null +++ b/src/mainboard/google/brya/variants/meliks/include/variant/gpio.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef VARIANT_GPIO_H +#define VARIANT_GPIO_H + +#include <baseboard/gpio.h> + +#endif diff --git a/src/mainboard/google/brya/variants/meliks/memory/Makefile.mk b/src/mainboard/google/brya/variants/meliks/memory/Makefile.mk new file mode 100644 index 0000000..eace2e4 --- /dev/null +++ b/src/mainboard/google/brya/variants/meliks/memory/Makefile.mk @@ -0,0 +1,5 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# This is an auto-generated file. Do not edit!! +# Add memory parts in mem_parts_used.txt and run spd_tools to regenerate. + +SPD_SOURCES = placeholder diff --git a/src/mainboard/google/brya/variants/meliks/memory/dram_id.generated.txt b/src/mainboard/google/brya/variants/meliks/memory/dram_id.generated.txt new file mode 100644 index 0000000..fa24790 --- /dev/null +++ b/src/mainboard/google/brya/variants/meliks/memory/dram_id.generated.txt @@ -0,0 +1 @@ +DRAM Part Name ID to assign diff --git a/src/mainboard/google/brya/variants/meliks/memory/mem_parts_used.txt b/src/mainboard/google/brya/variants/meliks/memory/mem_parts_used.txt new file mode 100644 index 0000000..2499005 --- /dev/null +++ b/src/mainboard/google/brya/variants/meliks/memory/mem_parts_used.txt @@ -0,0 +1,11 @@ +# This is a CSV file containing a list of memory parts used by this variant. +# One part per line with an optional fixed ID in column 2. +# Only include a fixed ID if it is required for legacy reasons! +# Generated IDs are dependent on the order of parts in this file, +# so new parts must always be added at the end of the file! +# +# Generate an updated Makefile.mk and dram_id.generated.txt by running the +# part_id_gen tool from util/spd_tools. +# See util/spd_tools/README.md for more details and instructions. + +# Part Name diff --git a/src/mainboard/google/brya/variants/meliks/overridetree.cb b/src/mainboard/google/brya/variants/meliks/overridetree.cb new file mode 100644 index 0000000..4f2c04a --- /dev/null +++ b/src/mainboard/google/brya/variants/meliks/overridetree.cb @@ -0,0 +1,6 @@ +chip soc/intel/alderlake + + device domain 0 on + end + +end
-
Matt DeVillier (Code Review)