Srinidhi N Kaushik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37887 )
Change subject: mb/intel/tglrvp: Add ACPI support for CNVi ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37887/3/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/acpi/cnvi.asl:
PS3:
Where did you get this file from. coreboot ASL files are using tabs for indentation to my knowledge.
Ack
https://review.coreboot.org/c/coreboot/+/37887/3/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/37887/3/src/mainboard/intel/tglrvp/... PS3, Line 43: //Cnvi support
Space after //.
Ack