Attention is currently required from: Andrey Petrov, Ronak Kanabar, Shuo Liu, Subrata Banik.
Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80691?usp=email )
Change subject: drivers/intel/fsp2_0: Initialize CPUs only when FSP-S has completed
......................................................................
Patch Set 3:
(1 comment)
File src/drivers/intel/fsp2_0/silicon_init.c:
https://review.coreboot.org/c/coreboot/+/80691/comment/6ab48492_88b33ebd :
PS3, Line 204: USE_INTEL_FSP_MP_INIT
side question: what is the motivation of not using coreboot using MP init and using `USE_INTEL_FSP_M […]
Since this option exist, the idea of this patch is to keep working for new platforms. I indeed noticed that no configuration are using it. if we think this options does not make sense, shouldn't we just remove it altogether ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80691?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If0397f5cc8d0f4f1872bd37a001fe42e0c37ec92
Gerrit-Change-Number: 80691
Gerrit-PatchSet: 3
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Comment-Date: Tue, 05 Mar 2024 04:19:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment