Attention is currently required from: David Hendricks, Paul Menzel, Vanessa Eusebio, Michal Motyl, Patrick Rudolph, Felix Held.
King Sumo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57033 )
Change subject: soc/intel/denverton_ns: Fix MRC cache write
......................................................................
Patch Set 2: Code-Review-1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57033/comment/a82d83eb_4be43313
PS1, Line 10:
Please give a little more details on how it fails.
Done
https://review.coreboot.org/c/coreboot/+/57033/comment/453e2c33_4a7f7ae8
PS1, Line 12: Change-Id: I50cc4f8ced0b0524b39eece5a2bb4f0d99fb4eff
Please add a tag: Link: https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot. […]
Done
Commit Message:
https://review.coreboot.org/c/coreboot/+/57033/comment/77ea3c3f_ed52f8c9
PS2, Line 15: Signed-off-by: King Sumo kingsumos@gmail.com
i'm not sure if pseudonyms can be used in the signed off by line, so i'm hesitant to click submit on […]
Hi Felix, I can handover the patch to someone else, no problem at all. I don't mind regarding credits, in fact the solution was pointed out by Mariusz - I was trying to speed up things ;)
Patchset:
PS2:
@Mariusz could you please takeover the changes so we can move forward?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57033
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I50cc4f8ced0b0524b39eece5a2bb4f0d99fb4eff
Gerrit-Change-Number: 57033
Gerrit-PatchSet: 2
Gerrit-Owner: King Sumo
kingsumos@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: King Sumo
kingsumos@gmail.com
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Michal Motyl
michalx.motyl@intel.com
Gerrit-Reviewer: Name of user not set #1001763
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Michal Motyl
michalx.motyl@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 25 Aug 2021 17:59:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment