Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50337 )
Change subject: soc/amd/picasso: Move memmap_early_dram to common blocks
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/soc/amd/common/block/include/amdblocks/memmap.h:
https://review.coreboot.org/c/coreboot/+/50337/comment/6bdece40_a3088d4f
PS1, Line 13: uint32_t size;
I wonder if these should be `uintptr_t base` and `size_t size`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50337
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0800c662bb473eb571c74e76a8247298f534b53f
Gerrit-Change-Number: 50337
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Sun, 07 Feb 2021 14:44:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment