Attention is currently required from: Saurabh Mishra, Kangheui Won, Rizwan Qureshi.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63707 )
Change subject: vendorcode/intel/fsp: Update FSP header file for Alder Lake N FSP v3133.00
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63707/comment/c7f7fee0_73b22f9e
PS1, Line 9: The headers added are generated as per FSP v3133.00
: Previous FSP version was v3054.02
: Changes Include:
Formatting is used from previous CL: https://review.coreboot. […]
And? Then reviewers missed it.
Please do not break the line after sentences if it’s not a new paragraph, or the line length is not met yet.
Please add a dot/period to the end of sentences.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63707
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b921e2aa467597a1c764fc554e2e83e5bb542e8
Gerrit-Change-Number: 63707
Gerrit-PatchSet: 2
Gerrit-Owner: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Reka Norman
rekanorman@chromium.org
Gerrit-CC: Saurabh Mishra
mishra.saurabh@intel.corp-partner.google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Saurabh Mishra
mishra.saurabh@intel.corp-partner.google.com
Gerrit-Comment-Date: Tue, 19 Apr 2022 15:35:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Saurabh Mishra
mishra.saurabh@intel.corp-partner.google.com
Gerrit-MessageType: comment