Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38790 )
Change subject: Makefile.inc: Adapt $(spc) definition, gmake 4.3 is picky ......................................................................
Makefile.inc: Adapt $(spc) definition, gmake 4.3 is picky
The old definition worked for nearly 8 years, RIP.
Change-Id: I7981e0066b550251ae4a98d7b50e83049fc5586a Signed-off-by: Nico Huber nico.h@gmx.de --- M Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/38790/1
diff --git a/Makefile.inc b/Makefile.inc index 4ca173b..7b4dcb3 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -159,7 +159,7 @@ ####################################################################### # Helper functions for ramstage postprocess spc := -spc += +spc := $(spc) $(spc) comma := ,
# Returns all files and dirs below `dir` (recursively).
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38790 )
Change subject: Makefile.inc: Adapt $(spc) definition, gmake 4.3 is picky ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/38790/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38790/1//COMMIT_MSG@7 PS1, Line 7: gmake 4.3 is picky Maybe put this in the commit message
https://review.coreboot.org/c/coreboot/+/38790/1//COMMIT_MSG@9 PS1, Line 9: The old definition worked for nearly 8 years, RIP. Tested and working with versions 4.3 and 4.2.1 of GNU make.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38790 )
Change subject: Makefile.inc: Adapt $(spc) definition, gmake 4.3 is picky ......................................................................
Patch Set 1: Code-Review+1
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38790 )
Change subject: Makefile.inc: Adapt $(spc) definition, gmake 4.3 is picky ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38790/1//COMMIT_MSG Commit Message:
PS1: So there's room for improvement on the commit message, but I'd just let it in, too. Nico, what's your preference: do you want to revise it or get it in as-is?
Hello Angel Pons, Paul Menzel, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38790
to look at the new patch set (#2).
Change subject: Makefile.inc: Adapt $(spc) definition ......................................................................
Makefile.inc: Adapt $(spc) definition
GNU Make 4.3 is more picky about the $(spc) definition. It seems, the variable ends up empty. The old definition worked for nearly 8 years, RIP.
Tested with GNU Make 4.2.1 and 4.3.
Change-Id: I7981e0066b550251ae4a98d7b50e83049fc5586a Signed-off-by: Nico Huber nico.h@gmx.de --- M Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/38790/2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38790 )
Change subject: Makefile.inc: Adapt $(spc) definition ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38790/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38790/1//COMMIT_MSG@7 PS1, Line 7: gmake 4.3 is picky
Maybe put this in the commit message
Done
https://review.coreboot.org/c/coreboot/+/38790/1//COMMIT_MSG@9 PS1, Line 9: The old definition worked for nearly 8 years, RIP.
Tested and working with versions 4.3 and 4.2.1 of GNU make.
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38790 )
Change subject: Makefile.inc: Adapt $(spc) definition ......................................................................
Makefile.inc: Adapt $(spc) definition
GNU Make 4.3 is more picky about the $(spc) definition. It seems, the variable ends up empty. The old definition worked for nearly 8 years, RIP.
Tested with GNU Make 4.2.1 and 4.3.
Change-Id: I7981e0066b550251ae4a98d7b50e83049fc5586a Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/38790 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/Makefile.inc b/Makefile.inc index 648bc4f..1f18726 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -159,7 +159,7 @@ ####################################################################### # Helper functions for ramstage postprocess spc := -spc += +spc := $(spc) $(spc) comma := ,
# Returns all files and dirs below `dir` (recursively).
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38790 )
Change subject: Makefile.inc: Adapt $(spc) definition ......................................................................
Patch Set 3:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/565 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/564 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/563
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)