[M] Change in coreboot[main]: mb/intel/adlrvp: Add Realtek ALC256 audio verb table

[Vamshi Krishna Gopal (Code Review)]

Attention is currently required from: Arthur Heymans, Karthik Ramasubramanian, Krishna P Bhat D, Nick Vaccaro, Paul Menzel, Poornima Tom, Subrata Banik, Vamshi Krishna Gopal.

Vamshi Krishna Gopal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79415?usp=email )

Change subject: mb/intel/adlrvp: Add Realtek ALC256 audio verb table
......................................................................

Patch Set 7:

(1 comment)

Patchset:

PS7:
> > Subrata, I just relooked into the other designs where we are using verb table, (eg: src/mainboard/starlabs/starbook/variants/tgl/hda_verb.c) , Verb table holds register values for multiple audio endpoint and for chrome designs these values are same most of the time but in few rare cases where we need some tunning
>
> can you please point me to the endpoint configuration section belongs to the verb table ?

To give an overview on endpoints , we can look into the each widget NID (node id)defined , each widget NID is mapped to corresponding applicable endpoints based on codec.
to operate the codec we send the instructions in verbs (32-bit registers),31:28 reserved bit, 27:20 indicates NID ,  19:8 verb id , 0:7 payload bits.

the current widget NID for ALC256 endpoints are mapped like this

NID 0x01 : CODEC power reset 
    NID 0x12 : CODEC DMIC
    NID 0x13 : CODEC DMIC
    NID 0x14 : front jack , lineout for jack device
    NID 0x18 : MIC1 , mic input for MIC device
    NID 0x19 : MIC2 , mic input for MIC device
    NID 0x1A : Line1 jack, Linein for jack device
    NID 0x1B : NPC audio effect
    NID 0x1D : BEEP-IN, input for codec beep
    NID 0x1E : SPDIF-OUT, S/PDIF out device
    NID 0x21 : Line2 jack, Headphone out for jack device
    NID 0x20 : for codec common settings
> > or we dont want custom set of endpoints wrt design needs,  we wont be able to change them if we have verb table as generic, so i was thinking
>
> based on your response, i might be able to share some further thoughts
> > we can have 2 options here,
> > If the current design audio endpoints aligns with generic verb table we can use generic verbtable.
> > If the current design audio endpoints doesnt align with generic verb table we can have custome verbtable specific to that design.
> >
> > Let me know your thoughts.
>
> I agree with you.