Attention is currently required from: Andy Pont, Paul Menzel, Angel Pons, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58343 )
Change subject: ec/starlabs: Add standardised ITE EC support
......................................................................
Patch Set 33:
(2 comments)
File src/ec/starlabs/merlin/ec.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133037):
https://review.coreboot.org/c/coreboot/+/58343/comment/9f7ee426_a24514a4
PS33, Line 210: 2));
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133037):
https://review.coreboot.org/c/coreboot/+/58343/comment/ed3936b2_e70a1f61
PS33, Line 210: 2));
please, no space before tabs
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58343
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8023c26de23c874c84106fda96e64dcfa0c5ba32
Gerrit-Change-Number: 58343
Gerrit-PatchSet: 33
Gerrit-Owner: Sean Rhodes
admin@starlabs.systems
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andy Pont
andy.pont@sdcsystems.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Andy Pont
andy.pont@sdcsystems.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 11 Nov 2021 15:32:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment